Skip to content

Commit ff2f73f

Browse files
authored
Merge pull request kubernetes-sigs#10906 from cahillsf/reenable-mhc-unit-test
🌱 Reenable 2 MHC unit tests
2 parents 9c08773 + 5050e3c commit ff2f73f

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

internal/controllers/machinehealthcheck/machinehealthcheck_controller_test.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -876,13 +876,11 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) {
876876
})
877877

878878
t.Run("when a Machine has no Node ref for longer than the NodeStartupTimeout", func(t *testing.T) {
879-
// FIXME: Resolve flaky/failing test
880-
t.Skip("skipping until made stable")
881879
g := NewWithT(t)
882880
cluster := createCluster(g, ns.Name)
883881

884882
mhc := newMachineHealthCheck(cluster.Namespace, cluster.Name)
885-
mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: time.Second}
883+
mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: 5 * time.Second}
886884

887885
g.Expect(env.Create(ctx, mhc)).To(Succeed())
888886
defer func(do ...client.Object) {
@@ -976,12 +974,11 @@ func TestMachineHealthCheck_Reconcile(t *testing.T) {
976974
})
977975

978976
t.Run("when a Machine's Node has gone away", func(t *testing.T) {
979-
// FIXME: Resolve flaky/failing test
980-
t.Skip("skipping until made stable")
981977
g := NewWithT(t)
982978
cluster := createCluster(g, ns.Name)
983979

984980
mhc := newMachineHealthCheck(cluster.Namespace, cluster.Name)
981+
mhc.Spec.NodeStartupTimeout = &metav1.Duration{Duration: 5 * time.Second}
985982

986983
g.Expect(env.Create(ctx, mhc)).To(Succeed())
987984
defer func(do ...client.Object) {

0 commit comments

Comments
 (0)