Skip to content

Engine should not call method from cyclone server #1137

@cd1989

Description

@cd1989

Is this a BUG REPORT or FEATURE REQUEST?:

/kind bug

Workflow Engine is lower level component of Cyclone, it should not be aware of Cyclone Server logic. So call method of Cyclone server is not allowed.

So this is not allowed:

https://github.com/caicloud/cyclone/blob/master/pkg/workflow/controller/handlers/workflowtrigger/cron_job.go#L19

What happened:

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Metadata

Metadata

Labels

kind/bugCategorizes issue or PR as related to a bug.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions