Fix bug resulting in incorrect Exceptions when automatically enumerating (as IAsyncEnumerable) Connection Pages when a request returns with no results (NextPage = false & EndCursor = null).

Author: cajuncoding

FlurlGraphQL/FlurlGraphQL.csproj

@@ -4,9 +4,9 @@
 		<!--NOTE: Just as with the base Flurl.Http.Newtonsoft library and Microsofts recommendation we now support net6 for the latest projects, but also netstandard2.1 which has proper Async streaming support, 
 				in addition to netstandard2.0 + net461 for legacy support (because netstandard2.0 it had API compatibility issues prior to .NET Framework 4.7.x -->
 		<TargetFrameworks>net461;netstandard2.0;netstandard2.1;net6.0;</TargetFrameworks>
-		<Version>2.0.1</Version>
-		<AssemblyVersion>2.0.1</AssemblyVersion>
-		<FileVersion>2.0.1</FileVersion>
+		<Version>2.0.2</Version>
+		<AssemblyVersion>2.0.2</AssemblyVersion>
+		<FileVersion>2.0.2</FileVersion>
 		<Authors>BBernard / CajunCoding</Authors>
 		<Company>CajunCoding</Company>
 		<Description>GraphQL client extensions for Flurl.Http -- lightweight, simplified, asynchronous, fluent GraphQL client API extensions for the amazing Flurl Http library!</Description>
@@ -17,9 +17,10 @@
 		<RepositoryUrl>https://github.com/cajuncoding/FlurlGraphQL</RepositoryUrl>
 		<PackageReleaseNotes>
 			Release Notes:
-			- Fix issue with incorrect deserialization when using wrapper convenience class GraphQLEdge&lt;T&gt;.
+			- Fix bug resulting in incorrect Exceptions when automatically enumerating (as IAsyncEnumerable) Connection Pages when a request returns with no results (NextPage = false & EndCursor = null).
 
 			Prior Release Notes:
+			- Fix issue with incorrect deserialization when using wrapper convenience class GraphQLEdge&lt;T&gt;.
 			- Implement full support for Flurl v4.0+
 			- Completely rewritten Json processing engine to now support both System.Text.Json &amp; Newtonsoft.Json.
 			- System.Text.Json processing with Json transformation strategy is now ~10X faster than the original Newtonsoft.Json processing.

FlurlGraphQL/FlurlGraphQL/FlurlGraphQLResponseExtensions.Internal.cs

@@ -79,13 +79,13 @@ Task<IFlurlGraphQLResponse> NextIterationResponseTask
 
             var originalGraphQLRequest = flurlGraphQLResponse.GraphQLRequest;
 
-            //If there is another page then Update our Variables and request the NEXT Page Asynchronously;
+            //If there is another page then Update our Variables and request the NEXT Page Asynchronously,
             //  otherwise set our iteration to null to stop processing!
-            var iterationResponseTask = !hasNextPage
-                ? null
-                : originalGraphQLRequest
+            var iterationResponseTask = hasNextPage
+                ? originalGraphQLRequest
                     .SetGraphQLVariable(GraphQLConnectionArgs.After, endCursor)
-                    .PostGraphQLQueryAsync(cancellationToken);
+                    .PostGraphQLQueryAsync(cancellationToken)
+                : null;
 
             //Update our tracking endCursor to the new one we recieved for the next iteration...
             return (pageResult, endCursor, iterationResponseTask);
@@ -136,7 +136,7 @@ Task<IFlurlGraphQLResponse> NextIterationResponseTask
         }
 
         internal static (bool HasNextPage, string EndCursor) AssertCursorPageIsValidForEnumeration(
-            IGraphQLCursorPageInfo pageInfo, 
+            IGraphQLCursorPageInfo pageInfo,
             IFlurlGraphQLResponseProcessor graphqlResponseProcessor, 
             FlurlGraphQLResponse flurlGraphQLResponse, 
             string priorEndCursor
@@ -148,10 +148,11 @@ string priorEndCursor
             bool? hasNextPageFlag = pageInfo.HasNextPage;
             string endCursor = pageInfo.EndCursor;
 
-            if (hasNextPageFlag == null || endCursor == null)
+            if (hasNextPageFlag == null || (hasNextPageFlag == true && endCursor == null))
                 throw NewGraphQLException(graphqlResponseProcessor, flurlGraphQLResponse,
                     "Unable to enumerate all pages because the pageInfo.hasNextPage and/or the pageInfo.endCursor values are not available in the GraphQL query response.");
-            else if (endCursor == priorEndCursor)
+            
+            if (endCursor == priorEndCursor)
                 throw NewGraphQLException(graphqlResponseProcessor, flurlGraphQLResponse,
                     "Unable to enumerate all pages because the pageInfo.endCursor is returning the same value. Check that the query is correct and that it correctly implements the (after:$after) variable.");