Merge pull request #4722 from peymanr34/fix-self-contained

GH4720: Use non-boolean self-contained arguments for dotnet publish.

Author: devlead

src/Cake.Common.Tests/Unit/Tools/DotNet/Publish/DotNetPublisherTests.cs

@@ -123,7 +123,7 @@ public void Should_Add_Settings()
                 var result = fixture.Run();
 
                 // Then
-                Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-build --no-dependencies --no-restore --nologo --force --self-contained true --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args);
+                Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-build --no-dependencies --no-restore --nologo --force --self-contained --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args);
             }
 
             [Fact]
@@ -147,7 +147,7 @@ public void Should_Add_SelfContained_False_Settings()
                 var result = fixture.Run();
 
                 // Then
-                Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-dependencies --no-restore --force --self-contained false --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args);
+                Assert.Equal("publish --output \"/Working/artifacts\" --runtime runtime1 --framework dnxcore50 --configuration Release --version-suffix rc1 --no-dependencies --no-restore --force --no-self-contained --source \"https://api.nuget.org/v3/index.json\" --verbosity minimal", result.Args);
             }
 
             [Fact]

src/Cake.Common/Tools/DotNet/Publish/DotNetPublisher.cs

@@ -125,14 +125,13 @@ private ProcessArgumentBuilder GetArguments(string path, DotNetPublishSettings s
             // Self contained
             if (settings.SelfContained.HasValue)
             {
-                builder.Append("--self-contained");
                 if (settings.SelfContained.Value)
                 {
-                    builder.Append("true");
+                    builder.Append("--self-contained");
                 }
                 else
                 {
-                    builder.Append("false");
+                    builder.Append("--no-self-contained");
                 }
             }