Add editorconfig and fix linting issues (#386)

* Add editorconfig
* Update ReSharper settings to match code
* Update to latest C# version
* Fix linting issues

Author: pascalberger

src/.editorconfig

@@ -0,0 +1,226 @@
+root = true
+# Remove the line below if you want to inherit .editorconfig settings from higher directories
+
+# C# files
+[*.cs]
+
+#### Core EditorConfig Options ####
+
+# Indentation and spacing
+indent_size = 4
+indent_style = space
+tab_width = 4
+
+# New line preferences
+end_of_line = crlf
+insert_final_newline = false
+
+#### .NET Coding Conventions ####
+
+# Organize usings
+dotnet_separate_import_directive_groups = false
+dotnet_sort_system_directives_first = true
+file_header_template = 
+
+# this. and Me. preferences
+dotnet_style_qualification_for_event = true
+dotnet_style_qualification_for_field = true
+dotnet_style_qualification_for_method = true
+dotnet_style_qualification_for_property = true
+
+# Language keywords vs BCL types preferences
+dotnet_style_predefined_type_for_locals_parameters_members = true
+dotnet_style_predefined_type_for_member_access = true
+
+# Parentheses preferences
+dotnet_style_parentheses_in_arithmetic_binary_operators = always_for_clarity
+dotnet_style_parentheses_in_other_binary_operators = always_for_clarity
+dotnet_style_parentheses_in_other_operators = never_if_unnecessary
+dotnet_style_parentheses_in_relational_binary_operators = always_for_clarity
+
+# Modifier preferences
+dotnet_style_require_accessibility_modifiers = for_non_interface_members
+
+# Expression-level preferences
+dotnet_style_coalesce_expression = true
+dotnet_style_collection_initializer = true
+dotnet_style_explicit_tuple_names = true
+dotnet_style_namespace_match_folder = true
+dotnet_style_null_propagation = true
+dotnet_style_object_initializer = true
+dotnet_style_operator_placement_when_wrapping = beginning_of_line
+dotnet_style_prefer_auto_properties = true
+dotnet_style_prefer_compound_assignment = true
+dotnet_style_prefer_conditional_expression_over_assignment = true
+dotnet_style_prefer_conditional_expression_over_return = true
+dotnet_style_prefer_foreach_explicit_cast_in_source = when_strongly_typed
+dotnet_style_prefer_inferred_anonymous_type_member_names = true
+dotnet_style_prefer_inferred_tuple_names = true
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true
+dotnet_style_prefer_simplified_boolean_expressions = true
+dotnet_style_prefer_simplified_interpolation = true
+
+# Field preferences
+dotnet_style_readonly_field = true
+
+# Parameter preferences
+dotnet_code_quality_unused_parameters = all
+
+# Suppression preferences
+dotnet_remove_unnecessary_suppression_exclusions = 0
+
+# New line preferences
+dotnet_style_allow_multiple_blank_lines_experimental = true
+dotnet_style_allow_statement_immediately_after_block_experimental = true
+
+#### C# Coding Conventions ####
+
+# var preferences
+csharp_style_var_elsewhere = true:suggestion
+csharp_style_var_for_built_in_types = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+
+# Expression-bodied members
+csharp_style_expression_bodied_accessors = true
+csharp_style_expression_bodied_constructors = false
+csharp_style_expression_bodied_indexers = true
+csharp_style_expression_bodied_lambdas = true
+csharp_style_expression_bodied_local_functions = false
+csharp_style_expression_bodied_methods = false
+csharp_style_expression_bodied_operators = false
+csharp_style_expression_bodied_properties = true
+
+# Pattern matching preferences
+csharp_style_pattern_matching_over_as_with_null_check = true
+csharp_style_pattern_matching_over_is_with_cast_check = true
+csharp_style_prefer_extended_property_pattern = true
+csharp_style_prefer_not_pattern = true
+csharp_style_prefer_pattern_matching = true
+csharp_style_prefer_switch_expression = true
+
+# Null-checking preferences
+csharp_style_conditional_delegate_call = true
+
+# Modifier preferences
+csharp_prefer_static_local_function = true
+csharp_preferred_modifier_order = public,private,protected,internal,static,extern,new,virtual,abstract,sealed,override,readonly,unsafe,volatile,async
+csharp_style_prefer_readonly_struct = true
+
+# Code-block preferences
+csharp_prefer_braces = true
+csharp_prefer_simple_using_statement = false
+csharp_style_namespace_declarations = block_scoped
+csharp_style_prefer_method_group_conversion = true
+csharp_style_prefer_top_level_statements = true
+
+# Expression-level preferences
+csharp_prefer_simple_default_expression = true
+csharp_style_deconstructed_variable_declaration = true
+csharp_style_implicit_object_creation_when_type_is_apparent = true
+csharp_style_inlined_variable_declaration = true
+csharp_style_prefer_index_operator = true
+csharp_style_prefer_local_over_anonymous_function = true
+csharp_style_prefer_null_check_over_type_check = true
+csharp_style_prefer_range_operator = true
+csharp_style_prefer_tuple_swap = true
+csharp_style_prefer_utf8_string_literals = true
+csharp_style_throw_expression = true
+csharp_style_unused_value_assignment_preference = discard_variable
+csharp_style_unused_value_expression_statement_preference = discard_variable
+
+# 'using' directive preferences
+csharp_using_directive_placement = inside_namespace:error
+
+# New line preferences
+csharp_style_allow_blank_line_after_colon_in_constructor_initializer_experimental = true
+csharp_style_allow_blank_lines_between_consecutive_braces_experimental = true
+csharp_style_allow_embedded_statements_on_same_line_experimental = true
+
+#### C# Formatting Rules ####
+
+# New line preferences
+csharp_new_line_before_catch = true
+csharp_new_line_before_else = true
+csharp_new_line_before_finally = true
+csharp_new_line_before_members_in_anonymous_types = true
+csharp_new_line_before_members_in_object_initializers = true
+csharp_new_line_before_open_brace = all
+csharp_new_line_between_query_expression_clauses = true
+
+# Indentation preferences
+csharp_indent_block_contents = true
+csharp_indent_braces = false
+csharp_indent_case_contents = true
+csharp_indent_case_contents_when_block = true
+csharp_indent_labels = no_change
+csharp_indent_switch_labels = true
+
+# Space preferences
+csharp_space_after_cast = false
+csharp_space_after_colon_in_inheritance_clause = true
+csharp_space_after_comma = true
+csharp_space_after_dot = false
+csharp_space_after_keywords_in_control_flow_statements = true
+csharp_space_after_semicolon_in_for_statement = true
+csharp_space_around_binary_operators = before_and_after
+csharp_space_around_declaration_statements = false
+csharp_space_before_colon_in_inheritance_clause = true
+csharp_space_before_comma = false
+csharp_space_before_dot = false
+csharp_space_before_open_square_brackets = false
+csharp_space_before_semicolon_in_for_statement = false
+csharp_space_between_empty_square_brackets = false
+csharp_space_between_method_call_empty_parameter_list_parentheses = false
+csharp_space_between_method_call_name_and_opening_parenthesis = false
+csharp_space_between_method_call_parameter_list_parentheses = false
+csharp_space_between_method_declaration_empty_parameter_list_parentheses = false
+csharp_space_between_method_declaration_name_and_open_parenthesis = false
+csharp_space_between_method_declaration_parameter_list_parentheses = false
+csharp_space_between_parentheses = false
+csharp_space_between_square_brackets = false
+
+# Wrapping preferences
+csharp_preserve_single_line_blocks = true
+csharp_preserve_single_line_statements = true
+
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols = types
+dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.interface.required_modifiers = 
+
+dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
+dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.types.required_modifiers = 
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix = 
+dotnet_naming_style.begins_with_i.word_separator = 
+dotnet_naming_style.begins_with_i.capitalization = pascal_case

src/Cake.AzureDevOps.Tests/Repos/PullRequest/BasePullRequestFixture.cs

@@ -9,7 +9,7 @@ internal abstract class BasePullRequestFixture
         public const string ValidAzureDevOpsUrl = "https://my-account.visualstudio.com/DefaultCollection/MyProject/_git/MyRepoName";
         public const string InvalidUrl = "http://example.com";
 
-        public BasePullRequestFixture()
+        protected BasePullRequestFixture()
         {
             this.InitializeFakes();
         }

src/Cake.AzureDevOps.sln.DotSettings

@@ -1,3 +1,12 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArrangeThisQualifier/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ConvertToUsingDeclaration/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=MemberCanBePrivate_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ParameterHidesMember/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=RedundantNameQualifier/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnusedMember_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=UnusedType_002EGlobal/@EntryIndexedValue">DO_NOT_SHOW</s:String>
+	<s:String x:Key="/Default/CodeStyle/CodeFormatting/CSharpCodeStyle/ThisQualifier/INSTANCE_MEMBERS_QUALIFY_MEMBERS/@EntryValue">Field, Property, Event, Method</s:String>
+	
 	<s:String x:Key="/Default/CodeStyle/Naming/CSharpNaming/PredefinedNamingRules/=PrivateInstanceFields/@EntryIndexedValue">&lt;Policy Inspect="True" Prefix="" Suffix="" Style="aaBb" /&gt;</s:String></wpf:ResourceDictionary>

src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildQueryOrderExtensions.cs

@@ -14,23 +14,16 @@ internal static class AzureDevOpsBuildQueryOrderExtensions
         /// <returns>Converted query order.</returns>
         public static BuildQueryOrder ToBuildQueryOrder(this AzureDevOpsBuildQueryOrder queryOrder)
         {
-            switch (queryOrder)
+            return queryOrder switch
             {
-                case AzureDevOpsBuildQueryOrder.FinishTimeAscending:
-                    return BuildQueryOrder.FinishTimeAscending;
-                case AzureDevOpsBuildQueryOrder.FinishTimeDescending:
-                    return BuildQueryOrder.FinishTimeDescending;
-                case AzureDevOpsBuildQueryOrder.QueueTimeDescending:
-                    return BuildQueryOrder.QueueTimeDescending;
-                case AzureDevOpsBuildQueryOrder.QueueTimeAscending:
-                    return BuildQueryOrder.QueueTimeAscending;
-                case AzureDevOpsBuildQueryOrder.StartTimeDescending:
-                    return BuildQueryOrder.StartTimeDescending;
-                case AzureDevOpsBuildQueryOrder.StartTimeAscending:
-                    return BuildQueryOrder.StartTimeAscending;
-                default:
-                    throw new System.Exception("Unknown value");
-            }
+                AzureDevOpsBuildQueryOrder.FinishTimeAscending => BuildQueryOrder.FinishTimeAscending,
+                AzureDevOpsBuildQueryOrder.FinishTimeDescending => BuildQueryOrder.FinishTimeDescending,
+                AzureDevOpsBuildQueryOrder.QueueTimeDescending => BuildQueryOrder.QueueTimeDescending,
+                AzureDevOpsBuildQueryOrder.QueueTimeAscending => BuildQueryOrder.QueueTimeAscending,
+                AzureDevOpsBuildQueryOrder.StartTimeDescending => BuildQueryOrder.StartTimeDescending,
+                AzureDevOpsBuildQueryOrder.StartTimeAscending => BuildQueryOrder.StartTimeAscending,
+                _ => throw new System.Exception("Unknown value"),
+            };
         }
     }
 }

src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildResultExtensions.cs

@@ -14,21 +14,15 @@ internal static class AzureDevOpsBuildResultExtensions
         /// <returns>Converted build result.</returns>
         public static BuildResult ToBuildResult(this AzureDevOpsBuildResult result)
         {
-            switch (result)
+            return result switch
             {
-                case AzureDevOpsBuildResult.None:
-                    return BuildResult.None;
-                case AzureDevOpsBuildResult.Succeeded:
-                    return BuildResult.Succeeded;
-                case AzureDevOpsBuildResult.PartiallySucceeded:
-                    return BuildResult.PartiallySucceeded;
-                case AzureDevOpsBuildResult.Failed:
-                    return BuildResult.Failed;
-                case AzureDevOpsBuildResult.Canceled:
-                    return BuildResult.Canceled;
-                default:
-                    throw new System.Exception("Unknown value");
-            }
+                AzureDevOpsBuildResult.None => BuildResult.None,
+                AzureDevOpsBuildResult.Succeeded => BuildResult.Succeeded,
+                AzureDevOpsBuildResult.PartiallySucceeded => BuildResult.PartiallySucceeded,
+                AzureDevOpsBuildResult.Failed => BuildResult.Failed,
+                AzureDevOpsBuildResult.Canceled => BuildResult.Canceled,
+                _ => throw new System.Exception("Unknown value"),
+            };
         }
     }
 }

src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildStatusExtensions.cs

@@ -14,25 +14,17 @@ internal static class AzureDevOpsBuildStatusExtensions
         /// <returns>Converted state.</returns>
         public static BuildStatus ToBuildStatus(this AzureDevOpsBuildStatus status)
         {
-            switch (status)
+            return status switch
             {
-                case AzureDevOpsBuildStatus.None:
-                    return BuildStatus.None;
-                case AzureDevOpsBuildStatus.InProgress:
-                    return BuildStatus.InProgress;
-                case AzureDevOpsBuildStatus.Completed:
-                    return BuildStatus.Completed;
-                case AzureDevOpsBuildStatus.Cancelling:
-                    return BuildStatus.Cancelling;
-                case AzureDevOpsBuildStatus.Postponed:
-                    return BuildStatus.Postponed;
-                case AzureDevOpsBuildStatus.NotStarted:
-                    return BuildStatus.NotStarted;
-                case AzureDevOpsBuildStatus.All:
-                    return BuildStatus.All;
-                default:
-                    throw new System.Exception("Unknown value");
-            }
+                AzureDevOpsBuildStatus.None => BuildStatus.None,
+                AzureDevOpsBuildStatus.InProgress => BuildStatus.InProgress,
+                AzureDevOpsBuildStatus.Completed => BuildStatus.Completed,
+                AzureDevOpsBuildStatus.Cancelling => BuildStatus.Cancelling,
+                AzureDevOpsBuildStatus.Postponed => BuildStatus.Postponed,
+                AzureDevOpsBuildStatus.NotStarted => BuildStatus.NotStarted,
+                AzureDevOpsBuildStatus.All => BuildStatus.All,
+                _ => throw new System.Exception("Unknown value"),
+            };
         }
     }
 }

src/Cake.AzureDevOps/Pipelines/BuildResultExtensions.cs

@@ -14,21 +14,15 @@ internal static class BuildResultExtensions
         /// <returns>Converted build result.</returns>
         public static AzureDevOpsBuildResult ToAzureDevOpsBuildResult(this BuildResult result)
         {
-            switch (result)
+            return result switch
             {
-                case BuildResult.None:
-                    return AzureDevOpsBuildResult.None;
-                case BuildResult.Succeeded:
-                    return AzureDevOpsBuildResult.Succeeded;
-                case BuildResult.PartiallySucceeded:
-                    return AzureDevOpsBuildResult.PartiallySucceeded;
-                case BuildResult.Failed:
-                    return AzureDevOpsBuildResult.Failed;
-                case BuildResult.Canceled:
-                    return AzureDevOpsBuildResult.Canceled;
-                default:
-                    throw new System.Exception("Unknown value");
-            }
+                BuildResult.None => AzureDevOpsBuildResult.None,
+                BuildResult.Succeeded => AzureDevOpsBuildResult.Succeeded,
+                BuildResult.PartiallySucceeded => AzureDevOpsBuildResult.PartiallySucceeded,
+                BuildResult.Failed => AzureDevOpsBuildResult.Failed,
+                BuildResult.Canceled => AzureDevOpsBuildResult.Canceled,
+                _ => throw new System.Exception("Unknown value"),
+            };
         }
     }
 }