Fix linting issues (#391)

Author: pascalberger

src/Cake.AzureDevOps.Tests/BaseAzureDevOpsCollectionSettingsImpl.cs

@@ -1,4 +1,4 @@
-namespace Cake.AzureDevOps
+namespace Cake.AzureDevOps.Tests
 {
     using System;
     using Cake.AzureDevOps.Authentication;

src/Cake.AzureDevOps.Tests/BaseAzureDevOpsProjectSettingsImpl.cs

@@ -1,4 +1,4 @@
-namespace Cake.AzureDevOps
+namespace Cake.AzureDevOps.Tests
 {
     using System;
     using Cake.AzureDevOps.Authentication;

src/Cake.AzureDevOps.Tests/Boards/WorkItemTracking/AzureDevOpsWorkItemSettingsTests.cs

@@ -34,7 +34,7 @@ public override BuildHttpClient CreateBuildClient(Uri collectionUrl, IAzureDevOp
             mock.Setup(arg => arg.GetBuildWorkItemsRefsAsync(It.IsAny<string>(), It.IsAny<int>(), It.IsAny<int?>(), null, default))
                .ReturnsAsync((string projectName, int buildId, int? top, object userState, CancellationToken token) => new List<ResourceRef>
                {
-                  new ResourceRef { Id = "42" },
+                  new () { Id = "42" },
                });
 
             mock = this.Setup(mock);

src/Cake.AzureDevOps.Tests/Fakes/FakeAllSetBuildClientFactory.cs

@@ -105,14 +105,14 @@ protected override Mock<GitHttpClient> Setup(Mock<GitHttpClient> m)
             // Setup CommitDiffs object
             var gitChanges = new List<GitChange>
             {
-                new GitChange
+                new ()
                 {
                     ChangeId = 1,
                     ChangeType = VersionControlChangeType.Edit,
                     Item = new GitItem("/src/project/myclass.cs", "ID1", GitObjectType.Commit, "6b13ff8", 0),
                 },
                 null,
-                new GitChange
+                new ()
                 {
                     ChangeId = 2,
                     ChangeType = VersionControlChangeType.Edit,
@@ -152,7 +152,7 @@ protected override Mock<GitHttpClient> Setup(Mock<GitHttpClient> m)
             // Setup GitPullRequestCommentThread collection
             var commentThreads = new List<GitPullRequestCommentThread>
             {
-                new GitPullRequestCommentThread
+                new ()
                 {
                     Id = 11,
                     ThreadContext = new CommentThreadContext()
@@ -161,12 +161,12 @@ protected override Mock<GitHttpClient> Setup(Mock<GitHttpClient> m)
                     },
                     Comments = new List<Comment>
                     {
-                        new Comment { Content = "Hello", IsDeleted = false, CommentType = CommentType.CodeChange, Id = 1 },
-                        new Comment { Content = "Goodbye", IsDeleted = true, CommentType = CommentType.Text, Id = 2 },
+                        new () { Content = "Hello", IsDeleted = false, CommentType = CommentType.CodeChange, Id = 1 },
+                        new () { Content = "Goodbye", IsDeleted = true, CommentType = CommentType.Text, Id = 2 },
                     },
                     Status = CommentThreadStatus.Active,
                 },
-                new GitPullRequestCommentThread
+                new ()
                 {
                     Id = 22,
                     ThreadContext = null,
@@ -203,8 +203,8 @@ protected override Mock<GitHttpClient> Setup(Mock<GitHttpClient> m)
              .ReturnsAsync((Guid repoId, int prId, bool? b, object o, CancellationToken c)
                     => new List<GitPullRequestIteration>
                     {
-                        new GitPullRequestIteration { Id = 42, CreatedDate = DateTime.Today.AddDays(-3) },
-                        new GitPullRequestIteration { Id = 16, CreatedDate = DateTime.Today.AddDays(-1) },
+                        new () { Id = 42, CreatedDate = DateTime.Today.AddDays(-3) },
+                        new () { Id = 16, CreatedDate = DateTime.Today.AddDays(-1) },
                     });
 
             m.Setup(arg => arg.GetPullRequestIterationsAsync(
@@ -216,16 +216,16 @@ protected override Mock<GitHttpClient> Setup(Mock<GitHttpClient> m)
                 .ReturnsAsync((Guid repoId, int prId, bool? b, object o, CancellationToken c)
                     => new List<GitPullRequestIteration>
                     {
-                        new GitPullRequestIteration { Id = null },
+                        new () { Id = null },
                     });
 
             // Setup GitPullRequestIterationChanges collection
             var changes = new GitPullRequestIterationChanges
             {
                 ChangeEntries = new List<GitPullRequestChange>
                 {
-                    new GitPullRequestChange { ChangeId = 100, ChangeTrackingId = 1, Item = new GitItem { Path = "/src/my/class1.cs" } },
-                    new GitPullRequestChange { ChangeId = 200, ChangeTrackingId = 2, Item = new GitItem { Path = string.Empty } },
+                    new () { ChangeId = 100, ChangeTrackingId = 1, Item = new GitItem { Path = "/src/my/class1.cs" } },
+                    new () { ChangeId = 200, ChangeTrackingId = 2, Item = new GitItem { Path = string.Empty } },
                 },
             };
 
@@ -273,7 +273,7 @@ protected override Mock<GitHttpClient> Setup(Mock<GitHttpClient> m)
                 CancellationToken.None))
              .ReturnsAsync(() => new List<GitRef>()
              {
-                 new GitRef("master"),
+                 new ("master"),
              });
 
             m.Setup(

src/Cake.AzureDevOps.Tests/Fakes/FakeAllSetGitClientFactory.cs

@@ -22,13 +22,13 @@ public override TestManagementHttpClient CreateTestManagementClient(Uri collecti
                 {
                     ResultsForGroup = new List<TestResultsDetailsForGroup>()
                     {
-                        new TestResultsDetailsForGroup
+                        new ()
                         {
                             Results = new List<TestCaseResult>()
                             {
-                                new TestCaseResult { Id = 11, TestRun = new ShallowReference { Id = "1" } },
-                                new TestCaseResult { Id = 12, TestRun = new ShallowReference { Id = "1" } },
-                                new TestCaseResult { Id = 13, TestRun = new ShallowReference { Id = "1" } },
+                                new () { Id = 11, TestRun = new ShallowReference { Id = "1" } },
+                                new () { Id = 12, TestRun = new ShallowReference { Id = "1" } },
+                                new () { Id = 13, TestRun = new ShallowReference { Id = "1" } },
                             },
                         },
                     },
@@ -37,9 +37,9 @@ public override TestManagementHttpClient CreateTestManagementClient(Uri collecti
             mock.Setup(arg => arg.GetTestResultsAsync(It.IsAny<Guid>(), It.IsAny<int>(), null, It.IsAny<int?>(), It.IsAny<int?>(), It.IsAny<IEnumerable<TestOutcome>>(), null, default))
                 .ReturnsAsync((Guid projectId, int testRunId, ResultDetails? details, int? skip, int? top, IEnumerable<TestOutcome> outcomes, object userState, CancellationToken token) => new List<TestCaseResult>()
                 {
-                    new TestCaseResult { AutomatedTestName = "t1", Outcome = "Passed", ErrorMessage = string.Empty },
-                    new TestCaseResult { AutomatedTestName = "t2", Outcome = "Failed", ErrorMessage = "Error" },
-                    new TestCaseResult { AutomatedTestName = "t3", Outcome = "Passed", ErrorMessage = string.Empty },
+                    new () { AutomatedTestName = "t1", Outcome = "Passed", ErrorMessage = string.Empty },
+                    new () { AutomatedTestName = "t2", Outcome = "Failed", ErrorMessage = "Error" },
+                    new () { AutomatedTestName = "t3", Outcome = "Passed", ErrorMessage = string.Empty },
                 }.Take(top.Value).ToList());
 
             mock = this.Setup(mock);

src/Cake.AzureDevOps.Tests/Fakes/FakeAllSetTestManagementClientFactory.cs

@@ -2,9 +2,9 @@
 {
     using System;
     using System.Collections.Generic;
+    using System.Linq;
     using System.Threading;
     using Cake.AzureDevOps.Authentication;
-    using Microsoft.TeamFoundation.TestManagement.WebApi;
     using Microsoft.TeamFoundation.WorkItemTracking.WebApi;
     using Microsoft.TeamFoundation.WorkItemTracking.WebApi.Models;
     using Moq;
@@ -18,14 +18,7 @@ public override WorkItemTrackingHttpClient CreateWorkItemTrackingClient(Uri coll
             mock.Setup(arg => arg.GetWorkItemsAsync(It.IsAny<IEnumerable<int>>(), It.IsAny<IEnumerable<string>>(), It.IsAny<DateTime?>(), It.IsAny<WorkItemExpand?>(), It.IsAny<WorkItemErrorPolicy?>(), null, default))
                 .ReturnsAsync((IEnumerable<int> workItemIds, IEnumerable<string> fields, DateTime? asOf, WorkItemExpand? expand, WorkItemErrorPolicy? errorPolicy, object userState, CancellationToken token) =>
                 {
-                    var result = new List<WorkItem>();
-
-                    foreach (var workItemId in workItemIds)
-                    {
-                        result.Add(new WorkItem { Id = workItemId });
-                    }
-
-                    return result;
+                    return workItemIds.Select(x => new WorkItem { Id = x }).ToList();
                 });
 
             mock = this.Setup(mock);

src/Cake.AzureDevOps.Tests/Fakes/FakeAllSetWorkItemTrackingClientFactory.cs

@@ -16,7 +16,7 @@ public BuildHttpClient CreateBuildClient(Uri collectionUrl, IAzureDevOpsCredenti
             return this.CreateBuildClient(collectionUrl, credentials);
         }
 
-        protected virtual Mock<BuildHttpClient> Setup(Mock<BuildHttpClient> m)
+        protected Mock<BuildHttpClient> Setup(Mock<BuildHttpClient> m)
         {
             return m;
         }

src/Cake.AzureDevOps.Tests/Fakes/FakeBuildClientFactory.cs

@@ -10,9 +10,9 @@ public abstract class FakeGitClientFactory : IGitClientFactory
     {
         public abstract GitHttpClient CreateGitClient(Uri collectionUrl, IAzureDevOpsCredentials credentials);
 
-        public GitHttpClient CreateGitClient(Uri collectionUrl, IAzureDevOpsCredentials credentials, out Identity identity)
+        public GitHttpClient CreateGitClient(Uri collectionUrl, IAzureDevOpsCredentials credentials, out Identity authorizedIdentity)
         {
-            identity = new Identity { ProviderDisplayName = "FakeUser", Id = Guid.NewGuid(), IsActive = true };
+            authorizedIdentity = new Identity { ProviderDisplayName = "FakeUser", Id = Guid.NewGuid(), IsActive = true };
             return this.CreateGitClient(collectionUrl, credentials);
         }
 

src/Cake.AzureDevOps.Tests/Fakes/FakeGitClientFactory.cs

@@ -1,7 +1,6 @@
 namespace Cake.AzureDevOps.Tests.Fakes
 {
     using System;
-    using System.Threading;
     using Cake.AzureDevOps.Authentication;
     using Microsoft.TeamFoundation.Build.WebApi;
     using Moq;