Skip to content

Commit b44c19c

Browse files
authored
Merge pull request #257 from pascalberger/feature/improve-testing
Allow to pass test management client factory
2 parents 1cf6a25 + badaaae commit b44c19c

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

src/Cake.AzureDevOps/AzureDevOpsAliases.Pipelines.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ public static AzureDevOpsBuild AzureDevOpsBuild(
4747
context.NotNull(nameof(context));
4848
settings.NotNull(nameof(settings));
4949

50-
var build = new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory());
50+
var build = new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory(), new TestManagementClientFactory());
5151

5252
if (build.HasBuildLoaded)
5353
{
@@ -204,7 +204,7 @@ public static bool AzureDevOpsBuildIsFailing(
204204
settings.NotNull(nameof(settings));
205205

206206
return
207-
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory())
207+
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory(), new TestManagementClientFactory())
208208
.IsBuildFailing();
209209
}
210210

@@ -252,7 +252,7 @@ public static IEnumerable<AzureDevOpsChange> AzureDevOpsBuildChanges(
252252
settings.NotNull(nameof(settings));
253253

254254
return
255-
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory())
255+
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory(), new TestManagementClientFactory())
256256
.GetChanges();
257257
}
258258

@@ -300,7 +300,7 @@ public static IEnumerable<AzureDevOpsTimelineRecord> AzureDevOpsBuildTimelineRec
300300
settings.NotNull(nameof(settings));
301301

302302
return
303-
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory())
303+
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory(), new TestManagementClientFactory())
304304
.GetTimelineRecords();
305305
}
306306

@@ -348,7 +348,7 @@ public static IEnumerable<AzureDevOpsBuildArtifact> AzureDevOpsBuildArtifacts(
348348
settings.NotNull(nameof(settings));
349349

350350
return
351-
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory())
351+
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory(), new TestManagementClientFactory())
352352
.GetArtifacts();
353353
}
354354

@@ -396,7 +396,7 @@ public static IEnumerable<AzureDevOpsTestRun> AzureDevOpsBuildTestRuns(
396396
settings.NotNull(nameof(settings));
397397

398398
return
399-
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory())
399+
new AzureDevOpsBuild(context.Log, settings, new BuildClientFactory(), new TestManagementClientFactory())
400400
.GetTestRuns();
401401
}
402402
}

src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuild.cs

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public sealed class AzureDevOpsBuild
2929
/// <exception cref="AzureDevOpsBuildNotFoundException">If <see cref="AzureDevOpsBuildSettings.ThrowExceptionIfBuildCouldNotBeFound"/>
3030
/// is set to <c>true</c> and no build could be found.</exception>
3131
public AzureDevOpsBuild(ICakeLog log, AzureDevOpsBuildSettings settings)
32-
: this(log, settings, new BuildClientFactory())
32+
: this(log, settings, new BuildClientFactory(), new TestManagementClientFactory())
3333
{
3434
}
3535

@@ -58,18 +58,24 @@ internal AzureDevOpsBuild(ICakeLog log, AzureDevOpsBuildsSettings settings, Buil
5858
/// </summary>
5959
/// <param name="log">The Cake log context.</param>
6060
/// <param name="settings">Settings for accessing AzureDevOps.</param>
61-
/// <param name="buildClientFactory">A factory to communicate with Build client.</param>
61+
/// <param name="buildClientFactory">A factory to communicate with build client.</param>
62+
/// <param name="testManagementClientFactory">A factory to communicate with test management client.</param>
6263
/// <exception cref="AzureDevOpsBuildNotFoundException">If <see cref="AzureDevOpsBuildSettings.ThrowExceptionIfBuildCouldNotBeFound"/>
6364
/// is set to <c>true</c> and no build could be found.</exception>
64-
internal AzureDevOpsBuild(ICakeLog log, AzureDevOpsBuildSettings settings, IBuildClientFactory buildClientFactory)
65+
internal AzureDevOpsBuild(
66+
ICakeLog log,
67+
AzureDevOpsBuildSettings settings,
68+
IBuildClientFactory buildClientFactory,
69+
ITestManagementClientFactory testManagementClientFactory)
6570
{
6671
log.NotNull(nameof(log));
6772
settings.NotNull(nameof(settings));
6873
buildClientFactory.NotNull(nameof(buildClientFactory));
74+
testManagementClientFactory.NotNull(nameof(testManagementClientFactory));
6975

7076
this.log = log;
7177
this.buildClientFactory = buildClientFactory;
72-
this.testClientFactory = new TestManagementClientFactory();
78+
this.testClientFactory = testManagementClientFactory;
7379
this.credentials = settings.Credentials;
7480
this.CollectionUrl = settings.CollectionUrl;
7581
this.throwExceptionIfBuildCouldNotBeFound = settings.ThrowExceptionIfBuildCouldNotBeFound;

0 commit comments

Comments
 (0)