Merge pull request #403 from cakephp/5.x-fix-error-with-no-type

fix error when phpdoc param has no type

Author: dereuromark

CakePHP/Sniffs/Commenting/TypeHintSniff.php

@@ -101,11 +101,16 @@ public function process(File $phpcsFile, $stackPtr)
                 continue;
             }
 
-            if ($valueNode->type instanceof UnionTypeNode) {
-                $types = $valueNode->type->types;
-            } elseif ($valueNode->type instanceof ArrayTypeNode) {
-                $types = [$valueNode->type];
+            if (isset($valueNode->type)) {
+                if ($valueNode->type instanceof UnionTypeNode) {
+                    $types = $valueNode->type->types;
+                } elseif ($valueNode->type instanceof ArrayTypeNode) {
+                    $types = [$valueNode->type];
+                } else {
+                    continue;
+                }
             } else {
+                $phpcsFile->addWarning('@param type hint is missing', $tag, 'MissingParamType');
                 continue;
             }
 

CakePHP/Tests/Commenting/TypeHintUnitTest.1.inc

@@ -22,6 +22,14 @@ class Foo
     public function testFunctionAnotations()
     {
     }
+
+    /**
+     * @param $test
+     * @return void
+     */
+    public function testNoParamTypeHint(string $test)
+    {
+    }
 }
 
 function test()

CakePHP/Tests/Commenting/TypeHintUnitTest.1.inc.fixed

@@ -22,6 +22,14 @@ class Foo
     public function testFunctionAnotations()
     {
     }
+
+    /**
+     * @param $test
+     * @return void
+     */
+    public function testNoParamTypeHint(string $test)
+    {
+    }
 }
 
 function test()

CakePHP/Tests/Commenting/TypeHintUnitTest.php

@@ -29,8 +29,9 @@ public function getWarningList($testFile = '')
                     9 => 1,
                     12 => 1,
                     15 => 1,
-                    29 => 1,
-                    34 => 1,
+                    27 => 1,
+                    37 => 1,
+                    42 => 1,
                 ];
 
             default: