Skip to content

Commit 565fa23

Browse files
committed
Fix vue linting errors
1 parent 170fdeb commit 565fa23

File tree

3 files changed

+36
-20
lines changed

3 files changed

+36
-20
lines changed

.vitepress/theme/components/PageLoader.vue

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
const visible = ref(false)
66
const router = useRouter()
77
8-
let before: (() => void) | null = null
9-
let after: (() => void) | null = null
8+
let before = null
9+
let after = null
1010
1111
onMounted(() => {
1212
before = () => { visible.value = true }
@@ -30,8 +30,11 @@
3030

3131
<template>
3232
<transition name="fade">
33-
<div v-if="visible" class="page-loader">
34-
<div class="page-loader-bar"></div>
33+
<div
34+
v-if="visible"
35+
class="page-loader"
36+
>
37+
<div class="page-loader-bar" />
3538
</div>
3639
</transition>
3740
</template>

.vitepress/theme/components/VersionDropdown.vue

Lines changed: 27 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<script setup>
2-
import { ref, computed, onMounted, onUnmounted, nextTick } from 'vue'
2+
import { ref, computed, onMounted, onUnmounted } from 'vue'
33
import { useRoute, useRouter, useData, withBase } from 'vitepress'
44
import { getVersionNavItems, getVersionByPath, getVersionLabel, isLocaleSupported } from '../../cake.js'
55
@@ -37,7 +37,7 @@ const closeDropdown = () => {
3737
isOpen.value = false
3838
}
3939
40-
const handleVersionClick = (version, event) => {
40+
const handleVersionClick = (version, _event) => {
4141
closeDropdown()
4242
4343
pendingVersionNavigation.value = {
@@ -97,22 +97,35 @@ onUnmounted(() => {
9797

9898
<template>
9999
<div class="version-dropdown">
100-
<button class="nav-dropdown-link" @click="toggleDropdown" :aria-expanded="isOpen">
100+
<button
101+
class="nav-dropdown-link"
102+
:aria-expanded="isOpen"
103+
@click="toggleDropdown"
104+
>
101105
{{ currentVersionText }}
102-
<span class="dropdown-arrow" :class="{ open: isOpen }">▼</span>
106+
<span
107+
class="dropdown-arrow"
108+
:class="{ open: isOpen }"
109+
>▼</span>
103110
</button>
104-
<ul v-show="isOpen" class="nav-dropdown-links">
105-
<li v-for="version in versionNavItems" :key="version.path">
111+
<ul
112+
v-show="isOpen"
113+
class="nav-dropdown-links"
114+
>
115+
<li
116+
v-for="version in versionNavItems"
117+
:key="version.path"
118+
>
106119
<a
107-
:href="withBase(version.link)"
108-
:class="{ active: withBase(version.path) === currentPath }"
109-
@click="handleVersionClick(version, $event)"
120+
:href="withBase(version.link)"
121+
:class="{ active: withBase(version.path) === currentPath }"
122+
@click="handleVersionClick(version, $event)"
110123
>
111-
{{ version.text }}
112-
</a>
113-
</li>
114-
</ul>
115-
</div>
124+
{{ version.text }}
125+
</a>
126+
</li>
127+
</ul>
128+
</div>
116129
</template>
117130

118131
<style scoped>

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"docs:dev": "vitepress dev",
1414
"docs:build": "vitepress build",
1515
"docs:preview": "vitepress preview",
16-
"lint": "eslint .vitepress/**/*.js validate-sidebar.js",
17-
"lint:fix": "eslint .vitepress/**/*.js validate-sidebar.js --fix"
16+
"lint": "eslint .vitepress/ validate-sidebar.js",
17+
"lint:fix": "eslint .vitepress/ validate-sidebar.js --fix"
1818
}
1919
}

0 commit comments

Comments
 (0)