Skip to content

Commit 742dce6

Browse files
committed
use assertEquals
Signed-off-by: Matthew Peveler <[email protected]>
1 parent 3927ee4 commit 742dce6

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

tests/Phinx/Db/Adapter/MysqlAdapterTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2217,7 +2217,7 @@ public function testBulkInsertLiteral()
22172217
$this->assertEquals('2025-01-01 00:00:00', $rows[2]['column2']);
22182218
}
22192219

2220-
public function testBulkInsertDates()
2220+
public function testBulkInsertDates(): void
22212221
{
22222222
$data = [
22232223
[
@@ -2237,8 +2237,8 @@ public function testBulkInsertDates()
22372237
$rows = $this->adapter->fetchAll('SELECT * FROM table1');
22382238
$this->assertEquals('foo', $rows[0]['name']);
22392239
$this->assertEquals('bar', $rows[1]['name']);
2240-
$this->assertMatchesRegularExpression($data[0]['created']->toDateTimeString(), $rows[0]['created']);
2241-
$this->assertMatchesRegularExpression($data[1]['created']->toDateTimeString(), $rows[1]['created']);
2240+
$this->assertEquals($data[0]['created']->toDateTimeString(), $rows[0]['created']);
2241+
$this->assertEquals($data[1]['created']->toDateTimeString(), $rows[1]['created']);
22422242
}
22432243

22442244
public function testInsertData()

tests/Phinx/Db/Adapter/PostgresAdapterTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2449,7 +2449,7 @@ public function testBulkInsertLiteral()
24492449
$this->assertEquals('2025-01-01 00:00:00', $rows[2]['column2']);
24502450
}
24512451

2452-
public function testBulkInsertDates()
2452+
public function testBulkInsertDates(): void
24532453
{
24542454
$data = [
24552455
[
@@ -2469,8 +2469,8 @@ public function testBulkInsertDates()
24692469
$rows = $this->adapter->fetchAll('SELECT * FROM table1');
24702470
$this->assertEquals('foo', $rows[0]['name']);
24712471
$this->assertEquals('bar', $rows[1]['name']);
2472-
$this->assertMatchesRegularExpression($data[0]['created']->toDateTimeString(), $rows[0]['created']);
2473-
$this->assertMatchesRegularExpression($data[1]['created']->toDateTimeString(), $rows[1]['created']);
2472+
$this->assertEquals($data[0]['created']->toDateTimeString(), $rows[0]['created']);
2473+
$this->assertEquals($data[1]['created']->toDateTimeString(), $rows[1]['created']);
24742474
}
24752475

24762476
public function testInsertData()

tests/Phinx/Db/Adapter/SQLiteAdapterTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1903,7 +1903,7 @@ public function testBulkInsertDataEnum()
19031903
$this->assertEquals('c', $rows[0]['column3']);
19041904
}
19051905

1906-
public function testBulkInsertDates()
1906+
public function testBulkInsertDates(): void
19071907
{
19081908
$data = [
19091909
[
@@ -1923,8 +1923,8 @@ public function testBulkInsertDates()
19231923
$rows = $this->adapter->fetchAll('SELECT * FROM table1');
19241924
$this->assertEquals('foo', $rows[0]['name']);
19251925
$this->assertEquals('bar', $rows[1]['name']);
1926-
$this->assertMatchesRegularExpression($data[0]['created']->toDateString(), $rows[0]['created']);
1927-
$this->assertMatchesRegularExpression($data[1]['created']->toDateTimeString(), $rows[1]['created']);
1926+
$this->assertEquals($data[0]['created']->toDateString(), $rows[0]['created']);
1927+
$this->assertEquals($data[1]['created']->toDateTimeString(), $rows[1]['created']);
19281928
}
19291929

19301930
public function testNullWithoutDefaultValue()

tests/Phinx/Db/Adapter/SqlServerAdapterTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,7 +1347,7 @@ public function testBulkInsertLiteral()
13471347
$this->assertEquals('2025-01-01 00:00:00.000', $rows[2]['column2']);
13481348
}
13491349

1350-
public function testBulkInsertDates()
1350+
public function testBulkInsertDates(): void
13511351
{
13521352
$data = [
13531353
[
@@ -1367,8 +1367,8 @@ public function testBulkInsertDates()
13671367
$rows = $this->adapter->fetchAll('SELECT * FROM table1');
13681368
$this->assertEquals('foo', $rows[0]['name']);
13691369
$this->assertEquals('bar', $rows[1]['name']);
1370-
$this->assertMatchesRegularExpression($data[0]['created']->toDateTimeString(), $rows[0]['created']);
1371-
$this->assertMatchesRegularExpression($data[1]['created']->toDateTimeString(), $rows[1]['created']);
1370+
$this->assertEquals($data[0]['created']->toDateTimeString(), $rows[0]['created']);
1371+
$this->assertEquals($data[1]['created']->toDateTimeString(), $rows[1]['created']);
13721372
}
13731373

13741374
public function testInsertData()

0 commit comments

Comments
 (0)