Merge pull request #1394 from garas/add-multiple-fulltext

Add FULLTEXT indexes on MySQL one at a time

Author: lorenzo

src/Phinx/Db/Adapter/MysqlAdapter.php

@@ -523,12 +523,28 @@ public function hasIndexByName($tableName, $indexName)
      */
     protected function getAddIndexInstructions(Table $table, Index $index)
     {
-        $alter = sprintf(
-            'ADD %s',
-            $this->getIndexSqlDefinition($index)
-        );
+        $instructions = new AlterInstructions();
 
-        return new AlterInstructions([$alter]);
+        if ($index->getType() == Index::FULLTEXT) {
+            // Must be executed separately
+            // SQLSTATE[HY000]: General error: 1795 InnoDB presently supports one FULLTEXT index creation at a time
+            $alter = sprintf(
+                'ALTER TABLE %s ADD %s',
+                $this->quoteTableName($table->getName()),
+                $this->getIndexSqlDefinition($index)
+            );
+
+            $instructions->addPostStep($alter);
+        } else {
+            $alter = sprintf(
+                'ADD %s',
+                $this->getIndexSqlDefinition($index)
+            );
+
+            $instructions->addAlter($alter);
+        }
+
+        return $instructions;
     }
 
     /**

tests/Phinx/Db/Adapter/MysqlAdapterTest.php

@@ -851,6 +851,27 @@ public function testAddIndex()
         $this->assertTrue($table->hasIndex('email'));
     }
 
+    public function testAddMultipleFulltextIndex()
+    {
+        $table = new \Phinx\Db\Table('table1', [], $this->adapter);
+        $table->addColumn('email', 'string')
+              ->addColumn('username', 'string')
+              ->addColumn('bio', 'text')
+              ->save();
+        $this->assertFalse($table->hasIndex('email'));
+        $this->assertFalse($table->hasIndex('username'));
+        $this->assertFalse($table->hasIndex('address'));
+        $table->addIndex('email')
+              ->addIndex('username', ['type' => 'fulltext'])
+              ->addIndex('bio', ['type' => 'fulltext'])
+              ->addIndex(['email', 'bio'], ['type' => 'fulltext'])
+              ->save();
+        $this->assertTrue($table->hasIndex('email'));
+        $this->assertTrue($table->hasIndex('username'));
+        $this->assertTrue($table->hasIndex('bio'));
+        $this->assertTrue($table->hasIndex(['email', 'bio']));
+    }
+
     public function testAddIndexWithLimit()
     {
         $table = new \Phinx\Db\Table('table1', [], $this->adapter);