Merge pull request #138 from cakephp/1.x-phpstan-l8

PHPStan level 8

Author: markstory

README.md

@@ -5,7 +5,7 @@
 [![Coverage Status](https://img.shields.io/codecov/c/github/cakephp/queue/master.svg?style=flat-square)](https://codecov.io/github/cakephp/queue?branch=master)
 [![Total Downloads](https://img.shields.io/packagist/dt/cakephp/queue.svg?style=flat-square)](https://packagist.org/packages/cakephp/queue)
 
-This is a Queue system for CakePHP 4.
+This is a Queue system for CakePHP.
 
 The plugin consists of a CakePHP shell wrapper and Queueing libraries for the [php-queue](https://php-enqueue.github.io) queue library.
 
@@ -34,7 +34,7 @@ bin/cake plugin load Cake/Queue
 
 Or you can manually add the loading statement in the **src/Application.php** file of your application:
 ```php
-public function bootstrap()
+public function bootstrap(): void
 {
     parent::bootstrap();
     $this->addPlugin('Cake/Queue');

composer.json

@@ -52,7 +52,7 @@
         ],
         "cs-check": "phpcs --colors -p src/ tests/",
         "cs-fix": "phpcbf --colors -p src/ tests/",
-        "stan": "phpstan analyse src/ && psalm.phar --show-info=false",
+        "stan": "phpstan analyse && psalm.phar --show-info=false",
         "stan-setup": "cp composer.json composer.backup && composer require --dev phpstan/phpstan:^1.5 psalm/phar:~4.22 && mv composer.backup composer.json",
         "test": "phpunit",
         "test-coverage": "phpunit --coverage-clover=clover.xml"

phpstan.neon

@@ -1,7 +1,11 @@
 parameters:
-	level: 6
+	level: 8
 	checkMissingIterableValueType: false
+	checkGenericClassInNonGenericObjectType: false
 	bootstrapFiles:
 		- tests/bootstrap.php
 	paths:
 		- src/
+	ignoreErrors:
+		- '#Parameter \#1 \$callback of static method Closure::fromCallable\(\) expects callable\(\): mixed, array\{mixed, string\} given.#'
+		- '#Method Cake\\Queue\\Job\\Message::getTarget\(\) should return array\{class-string, string\} but returns non-empty-array.#'

src/Job/Message.php

@@ -122,6 +122,7 @@ public function getCallable()
      */
     public function getTarget(): array
     {
+        /** @var array|null $target */
         $target = $this->parsedBody['class'] ?? null;
 
         if (!is_array($target) || count($target) !== 2) {
@@ -176,7 +177,7 @@ public function getMaxAttempts(): ?int
      */
     public function __toString()
     {
-        return json_encode($this);
+        return (string)json_encode($this);
     }
 
     /**

src/Listener/FailedJobsListener.php

@@ -38,7 +38,7 @@ public function implementedEvents(): array
     }
 
     /**
-     * @param object $event EventInterface.
+     * @param \Cake\Event\EventInterface $event EventInterface.
      * @return void
      */
     public function storeFailedJob($event): void

src/Model/Table/FailedJobsTable.php

@@ -11,25 +11,25 @@
  *
  * @method \Cake\Queue\Model\Entity\FailedJob newEmptyEntity()
  * @method \Cake\Queue\Model\Entity\FailedJob newEntity(array $data, array $options = [])
- * @method \Cake\Queue\Model\Entity\FailedJob[] newEntities(array $data, array $options = [])
+ * @method array<\Cake\Queue\Model\Entity\FailedJob> newEntities(array $data, array $options = [])
  * @method \Cake\Queue\Model\Entity\FailedJob get($primaryKey, $options = [])
  * @method \Cake\Queue\Model\Entity\FailedJob findOrCreate($search, ?callable $callback = null, $options = [])
  * @method \Cake\Queue\Model\Entity\FailedJob patchEntity(\Cake\Datasource\EntityInterface $entity, array $data, array $options = [])
- * @method \Cake\Queue\Model\Entity\FailedJob[] patchEntities(iterable $entities, array $data, array $options = [])
+ * @method array<\Cake\Queue\Model\Entity\FailedJob> patchEntities(iterable $entities, array $data, array $options = [])
  * @method \Cake\Queue\Model\Entity\FailedJob|false save(\Cake\Datasource\EntityInterface $entity, $options = [])
  * @method \Cake\Queue\Model\Entity\FailedJob saveOrFail(\Cake\Datasource\EntityInterface $entity, $options = [])
- * @method \Cake\Queue\Model\Entity\FailedJob[]|\Cake\Datasource\ResultSetInterface|false saveMany(iterable $entities, $options = [])
- * @method \Cake\Queue\Model\Entity\FailedJob[]|\Cake\Datasource\ResultSetInterface saveManyOrFail(iterable $entities, $options = [])
- * @method \Cake\Queue\Model\Entity\FailedJob[]|\Cake\Datasource\ResultSetInterface|false deleteMany(iterable $entities, $options = [])
- * @method \Cake\Queue\Model\Entity\FailedJob[]|\Cake\Datasource\ResultSetInterface deleteManyOrFail(iterable $entities, $options = [])
+ * @method iterable<\Cake\Queue\Model\Entity\FailedJob>|false saveMany(iterable $entities, $options = [])
+ * @method iterable<\Cake\Queue\Model\Entity\FailedJob> saveManyOrFail(iterable $entities, $options = [])
+ * @method iterable<\Cake\Queue\Model\Entity\FailedJob>|false deleteMany(iterable $entities, $options = [])
+ * @method iterable<\Cake\Queue\Model\Entity\FailedJob> deleteManyOrFail(iterable $entities, $options = [])
  * @mixin \Cake\ORM\Behavior\TimestampBehavior
  */
 class FailedJobsTable extends Table
 {
     /**
      * Initialize method
      *
-     * @param array $config The configuration for the Table.
+     * @param array<string, mixed> $config The configuration for the Table.
      * @return void
      */
     public function initialize(array $config): void