upgrade edn; no memory holding does not work

Author: tiye

.github/workflows/check.yaml

@@ -16,7 +16,7 @@ jobs:
 
       - uses: calcit-lang/[email protected]
         with:
-          version: "0.8.51-a4"
+          version: "0.8.51-a6"
 
       - uses: dtolnay/rust-toolchain@stable
         with:

Cargo.lock

@@ -13,8 +13,8 @@ crate-type = ["dylib"] # Creates dynamic lib
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-# cirru_edn = "0.6.4-a4"
-cirru_edn = { path = "/Users/chenyong/repo/cirru/edn.rs" }
+cirru_edn = "0.6.4-a5"
+# cirru_edn = { path = "/Users/chenyong/repo/cirru/edn.rs" }
 cirru_parser = "0.1.29"
 regex = "1.10.4"
 lazy_static = "1.4.0"

Cargo.toml

@@ -6,11 +6,6 @@
   :files $ {}
     |regex.core $ %{} :FileEntry
       :defs $ {}
-        |hold-patterns-memory! $ %{} :CodeEntry (:doc |)
-          :code $ quote
-            defn hold-patterns-memory! ()
-              &call-dylib-edn (get-dylib-path "\"/dylibs/libcalcit_regex") "\"holding_patterns_memory"
-              println "\"memory of regex patterns are set to hold!"
         |re-drop $ %{} :CodeEntry (:doc |)
           :code $ quote
             defn re-drop (pattern)
@@ -66,7 +61,6 @@
               assert= |1abXcX3 $ re-replace-all |1ab22c333 |\d{2} "\"X"
               assert= ([] "\"1ab" "\"c" "\"3") (re-split |1ab22c333 |\d{2})
               println "\"%%% test variable holding regex"
-              hold-patterns-memory!
               let
                   pattern $ re-pattern "\"\\d+"
                   p2 $ re-pattern "\"\\w+"
@@ -79,10 +73,11 @@
                 assert= |XabXcX $ re-replace-all |1ab22c333 pattern "\"X"
                 w-log $ re-drop p2
                 w-log $ re-drop pattern
+                w-log $ re-drop pattern
       :ns $ %{} :CodeEntry (:doc |)
         :code $ quote
           ns regex.test $ :require
-            regex.core :refer $ re-matches re-find-index re-find re-find-all re-split re-replace-all re-pattern re-drop hold-patterns-memory!
+            regex.core :refer $ re-matches re-find-index re-find re-find-all re-split re-replace-all re-pattern re-drop
             regex.$meta :refer $ calcit-dirname calcit-filename
     |regex.util $ %{} :FileEntry
       :defs $ {}

calcit.cirru

@@ -16,15 +16,6 @@ pub fn abi_version() -> String {
   String::from("0.0.8")
 }
 
-/// just call mem::forget to avoid GC
-#[no_mangle]
-pub fn holding_patterns_memory() -> Result<Edn, String> {
-  let patterns = PATTERNS.lock().unwrap();
-  let data = patterns.to_owned();
-  std::mem::forget(data);
-  Ok(Edn::Nil)
-}
-
 #[no_mangle]
 pub fn re_pattern(args: Vec<Edn>) -> Result<Edn, String> {
   if args.len() == 1 {