[CAL-2815] "Complete Your Booking" Payment Prompt Is Still Sent When Payment Has Been Received Via Collect Payment On Booking

[AlexIsMaking]

Issue Summary

The Complete Your Booking, Your meeting is awaiting payment email is still sent when payment has been received via collect payment on booking.

This email is confusing because it gives the person who booked the impression that their payment was not successful / received and unnecessary because the payment has already been received.

Steps to Reproduce

1. Go to events > apps > enable Stripe > configure pricing and select Collect Payment On Booking
2. Book the paid event and make the payment (I used Link as the payment method while testing)

Actual Results

You will receive the Complete Your Booking email, a receipt from Stripe and a booking confirmation email.

Expected Results

The Complete Your Booking email should not be sent.

Evidence

_{From SyncLinear.com | CAL-2815}

[github-actions]

Thank you for opening your first issue, one of our team members will review it as soon as it possible. ❤️🎉

[alannnc]

Right now we don't have a way to queue this email after X time has passed. So it should be like this for a while I think, after we came up with a way to queue/dequeue for cal.com

@zomars @joeauyeung Any ideas on this?

[hariombalhara]

I guess cron seems to be the only way like we do for other emails. We can schedule the email to be sent later like we do for Booking Request reminder. I am not sure if we send a payment reminder email but that would also be sorted with it.

We can schedule the email for a booking if it hasn't been paid for and requires payment and it's been say more than 15mins.

[AlexIsMaking]

We can schedule the email for a booking if it hasn't been paid for and requires payment and it's been say more than 15mins.

Please excuse me chipping in here but it sounds like there might be some confusion about this scenario.

I was under the impression that when Collect Payment On Booking was enabled, a booking could only be completed if the user pays as part of the booking process. If that's correct then I guess you might not need to wait to see whether the booking has been paid for or not?

[hariombalhara]

"I was under the impression that when Collect Payment On Booking was enabled, a booking could only be completed if the user pays as part of the booking process." Yes this is correct.
I meant that we should send reminders for payment to booker and stop them only when the booking has been paid for. First reminder should go fairly quick.

[AlexIsMaking]

Yes this is correct.

I meant that we should send reminders for payment to booker and stop them only when the booking has been paid for. First reminder should go fairly quick.

Ok great, I guess we're talking about different scenarios then because when I ran into this bug, Collect Payment On Booking was enabled so it sounds like there should be no need to send a reminder to pay to the booker at all?

[alannnc]

Apologies on the confusion there, Collect on booking still creates the booking first and then it prompts for payment detail on /payment page. That's why the email get sent first. We still can queue it but then we should find a way to stop it.