Add support for translations in subdirectories (larastan#2363)

Author: ramonrietdijk

src/Rules/NoMissingTranslationsRule.php

@@ -6,6 +6,7 @@
 
 use Illuminate\Filesystem\Filesystem;
 use Illuminate\Support\Arr;
+use Illuminate\Support\Str;
 use Larastan\Larastan\Collectors\UsedTranslationFacadeCollector;
 use Larastan\Larastan\Collectors\UsedTranslationFunctionCollector;
 use Larastan\Larastan\Collectors\UsedTranslationTranslatorCollector;
@@ -26,6 +27,9 @@
 use function is_dir;
 use function json_decode;
 use function lang_path;
+use function strlen;
+
+use const DIRECTORY_SEPARATOR;
 
 /** @implements Rule<CollectedDataNode> */
 final class NoMissingTranslationsRule implements Rule
@@ -69,8 +73,17 @@ public function processNode(Node $node, Scope $scope): array
                 $translations = [];
 
                 if ($file->getExtension() === 'php') {
+                    $prefix = Str::of($file->getRelativePathname())
+                        ->explode(DIRECTORY_SEPARATOR)
+                        ->slice(1, -1) // Trim locale and filename
+                        ->join('/');
+
+                    $key = strlen($prefix) > 0
+                        ? $prefix . '/' . $file->getFilenameWithoutExtension()
+                        : $file->getFilenameWithoutExtension();
+
                     $translations = Arr::dot([
-                        $file->getFilenameWithoutExtension() => $this->filesystem->getRequire($file->getPathname()),
+                        $key => $this->filesystem->getRequire($file->getPathname()),
                     ]);
                 } elseif ($file->getExtension() === 'json') {
                     $translations = json_decode($this->filesystem->get($file->getPathname()), true);

tests/Rules/NoMissingTranslationsRuleTest.php

@@ -67,6 +67,10 @@ public function testRule(): void
                 'Translation "messages.test" has not been found.',
                 32,
             ],
+            [
+                'Translation "sub/lines.farewell" has not been found.',
+                38,
+            ],
         ]);
     }
 

tests/Rules/data/Translation.php

@@ -33,5 +33,8 @@ public function translate(Translator $translator): void
 
         __('foo bar baz');
         __('messages.nested.key');
+
+        Lang::get('sub/lines.greeting');
+        Lang::get('sub/lines.farewell');
     }
 }

tests/application/resources/lang/en/sub/lines.php

@@ -0,0 +1,5 @@
+<?php
+
+return [
+    'greeting' => 'Hello world!',
+];