Reduced compiled size by removing AppendableStream

Author: calebsander

compiled/download.js

@@ -8,7 +8,7 @@ import AppendableBuffer from './appendable';
  * by calling [[end]] after all bytes
  * have been written.
  */
-export default class AppendableStream implements AppendableBuffer {
+export default class AppendableStream extends AppendableBuffer {
     private readonly outStream;
     private writtenBytes;
     private pauseCount;

compiled/upload-download.js

@@ -2,6 +2,7 @@
 Object.defineProperty(exports, "__esModule", { value: true });
 const http_1 = require("http");
 const stream_1 = require("stream");
+const appendable_1 = require("./appendable");
 const assert_1 = require("./assert");
 const growable_buffer_1 = require("./growable-buffer");
 const WRITABLE_STREAMS = [stream_1.Writable, stream_1.Duplex, http_1.OutgoingMessage];
@@ -12,11 +13,12 @@ const WRITABLE_STREAMS = [stream_1.Writable, stream_1.Duplex, http_1.OutgoingMes
  * by calling [[end]] after all bytes
  * have been written.
  */
-class AppendableStream {
+class AppendableStream extends appendable_1.default {
     /**
      * @param outStream The underlying writable stream
      */
     constructor(outStream) {
+        super();
         assert_1.default.instanceOf(outStream, WRITABLE_STREAMS);
         this.outStream = outStream;
         this.writtenBytes = 0;

compiled/upload.js

@@ -16,25 +16,25 @@
  * console.log(new Uint8Array(gb.toBuffer())) //Uint8Array [ 1, 2, 3, 4, 5 ]
  * ````
  */
-export default interface AppendableBuffer {
+export default abstract class AppendableBuffer {
     /**
      * The number of bytes that have been written
      */
-    readonly length: number;
+    readonly abstract length: number;
     /**
      * Adds a byte after the end
      * of the written data
      * @param value The unsigned byte value to add
      */
-    add(value: number): this;
+    abstract add(value: number): this;
     /**
      * Adds a contiguous set of bytes
      * after the end of the written data
      * @param buffer The bytes to add.
      * The byte at position `i` in `buffer` will be written to
      * position `this.length + i`.
      */
-    addAll(buffer: ArrayBuffer): this;
+    abstract addAll(buffer: ArrayBuffer): this;
     /**
      * Pauses the writing process, i.e.
      * bytes added are not written
@@ -59,14 +59,14 @@ export default interface AppendableBuffer {
      * console.log(new Uint8Array(gb.toBuffer())) //Uint8Array [ 1, 2, 3 ]
      * ````
      */
-    pause(): this;
+    abstract pause(): this;
     /**
      * See [[pause]].
      * Flushes all paused data to the output
      * and exits paused mode.
      * @throws If not currently paused
      */
-    resume(): this;
+    abstract resume(): this;
     /**
      * See [[pause]].
      * Restores state to immediately after
@@ -75,5 +75,5 @@ export default interface AppendableBuffer {
      * being flushed to the output.
      * @throws If not currently paused
      */
-    reset(): this;
+    abstract reset(): this;
 }

dist/lib/appendable-stream.d.ts

@@ -1,2 +1,23 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+/**
+ * A "writable" interface, sufficient
+ * to be able to write type and value bytes.
+ * Implemented by [[GrowableBuffer]], as well as
+ * [[AppendableStream]] (a wrapper around a writable stream).
+ * All methods can be chained, e.g.
+ * ````javascript
+ * let gb = new GrowableBuffer
+ * gb
+ *   .add(1).add(2)
+ *   .addAll(new Uint8Array([3, 4, 5]).buffer)
+ *   .pause()
+ *     .add(0)
+ *     .reset()
+ *   .resume()
+ * console.log(new Uint8Array(gb.toBuffer())) //Uint8Array [ 1, 2, 3, 4, 5 ]
+ * ````
+ */
+class AppendableBuffer {
+}
+exports.default = AppendableBuffer;

dist/lib/appendable-stream.js

@@ -6,7 +6,7 @@ import AppendableBuffer from './appendable';
  * Used extensively throughout the project for building up buffers.
  * See [[GrowableBuffer.grow]] for an explanation of the growing process.
  */
-export default class GrowableBuffer implements AppendableBuffer {
+export default class GrowableBuffer extends AppendableBuffer {
     private buffer;
     private size;
     private readonly pausePoints;

dist/lib/appendable.d.ts

@@ -1,5 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+const appendable_1 = require("./appendable");
 const assert_1 = require("./assert");
 const INITIAL_LENGTH = 10;
 /**
@@ -9,13 +10,14 @@ const INITIAL_LENGTH = 10;
  * Used extensively throughout the project for building up buffers.
  * See [[GrowableBuffer.grow]] for an explanation of the growing process.
  */
-class GrowableBuffer {
+class GrowableBuffer extends appendable_1.default {
     /**
      * @param initialLength
      * The number of bytes in the internal buffer at start
      * (defaults to 10)
      */
     constructor(initialLength = INITIAL_LENGTH) {
+        super();
         try {
             assert_1.default.integer(initialLength);
             assert_1.default(initialLength >= 0);

dist/lib/appendable.js

@@ -3,13 +3,12 @@ Object.defineProperty(exports, "__esModule", { value: true });
 const base64 = require("base64-js");
 const sha_256_1 = require("../lib/sha-256");
 const config_1 = require("../config");
-const appendable_stream_1 = require("../lib/appendable-stream");
+const appendable_1 = require("../lib/appendable");
 const assert_1 = require("../lib/assert");
 const constants_1 = require("../lib/constants");
 const flexInt = require("../lib/flex-int");
 const growable_buffer_1 = require("../lib/growable-buffer");
 const recursiveNesting = require("../lib/recursive-nesting");
-const APPENDABLES = [growable_buffer_1.default, appendable_stream_1.default];
 /**
  * The superclass of all [[Type]] classes
  * in this package
@@ -94,7 +93,7 @@ class AbstractType {
      * @param buffer The value to assert is an [[AppendableBuffer]]
      */
     isBuffer(buffer) {
-        assert_1.default.instanceOf(buffer, APPENDABLES);
+        assert_1.default.instanceOf(buffer, appendable_1.default);
     }
     /**
      * Generates the type buffer, recomputed each time