Segmentation

[volkv]

Hey there! Ive described the issue here
https://cod4x.me/index.php?/forums/topic/1069-mysql-segmentation-faults/
thanks

[T-Maxxx]

@volkv Please, check latest version.

[T-Maxxx]

Same crash backtrace here, but for other server version:
https://cod4x.me/index.php?/forums/topic/2133-mysql-plugin-segfault-linux/

[T-Maxxx]

OnFetchRow -> Scr_AddString -> SL_GetString -> some strlen issue?
Have to make sure I'm adding "good" string and this definetely mysql issue.

mysql/MySQLPlugin.cpp

Line 375 in 7652dfc

Plugin_Scr_AddString(row[i]);

<- change to string indexes?

[leiizko]

@T-Maxxx
row[i] is NULL pointer sometimes. For a temp fix I just added a check, but why it is null or if has any other impact I don't know. Seems to work fine for the moment

EDIT:
Problem happens when there is a column with NULL value. Plugin works just fine when every column has some actual value set.

[T-Maxxx]

@leiizko Makes sense. I saw that in SL_GetString there is code to calculate lenght of a string. This is not strlen call but some unusual asm instructions. You say row[i] is NULL: is this field can be a null in a table? If yes - than this is the answer how to fix this stuff: I'll just push "undefined" for this values.

[leiizko]

@T-Maxxx Yes the field can be null.
And while you're at it

---------- Crash Backtrace ----------
    8: ./cod4x18_dedrun(Sys_DumpCrash+0xe5) [0x20ab119]
    7: ./cod4x18_dedrun(Sys_SigHandler+0x3c) [0x20ab260]
    6: [0xf77f0400]
    5: ./plugin.libcod4x_mysql.tmp(list_length+0x10) [0xe2036440]
    4: ./plugin.libcod4x_mysql.tmp(free_state_change_info+0x29) [0xe201a2b9]
    3: ./plugin.libcod4x_mysql.tmp(mysql_send_query+0x37) [0xe201a357]
    2: ./plugin.libcod4x_mysql.tmp(mysql_real_query+0x30) [0xe201a420]
    1: ./plugin.libcod4x_mysql.tmp(mysql_query+0x35) [0xe2011975]
    0: ./plugin.libcod4x_mysql.tmp(_ZN12CMySQLPlugin14OnScript_QueryEv+0x7d) [0xe200c1ed]

-- Registers ---
edi 0x1455ed40
esi 0x1
ebp 0xffe6f530
esp 0xffe6f530
eax 0x0
ebx 0xe2394000
ecx 0x4
edx 0x8
eip 0xe2036440
-------- Backtrace Completed --------

Happens on second mysql_real_connect().