Merge pull request Expensify#69350 from callstack-internal/Migrate-rnef-to-rock

[NoQA] Migrate RNEF to ROCK

Author: mountiny

.github/scripts/verifyPodfile.sh

@@ -64,7 +64,7 @@ if ! SPEC_DIRS=$(yq '.["EXTERNAL SOURCES"].[].":path" | select( . == "*node_modu
 fi
 
 # Retrieve a list of podspec paths from react-native config
-if ! read_lines_into_array PODSPEC_PATHS < <(npx rnef config -p ios | jq --raw-output '.dependencies[].platforms.ios.podspecPath | select ( . != null)'); then
+if ! read_lines_into_array PODSPEC_PATHS < <(npx rock config -p ios | jq --raw-output '.dependencies[].platforms.ios.podspecPath | select ( . != null)'); then
   error "Error: could not parse podspec paths from react-native config command"
   cleanupAndExit 1
 fi

.github/workflows/remote-build-android.yml

@@ -47,14 +47,14 @@ jobs:
           git fetch origin pull/${{ github.event.inputs.mobile_expensify_pr }}/head:pr-${{ github.event.inputs.mobile_expensify_pr }}
           git checkout pr-${{ github.event.inputs.mobile_expensify_pr }}
           echo "Checked out Mobile-Expensify PR #${{ github.event.inputs.mobile_expensify_pr }}"
-
-      - name: RNEF Remote Build - Android
-        # rnef v2
-        uses: callstackincubator/android@d9a81f860e436ff2971323990244e32830dcabd1
+          
+      - name: Rock Remote Build - Android
+        # rock v3
+        uses: callstackincubator/android@1a7d52dfe3ca195ccbe5ad2f06c15f2fc3835115
         env:
           GITHUB_TOKEN: ${{ github.token }}
           IS_HYBRID_APP: ${{ matrix.is_hybrid_build }}
         with:
           variant: ${{ matrix.variant }}
-          rnef-build-extra-params: '--extra-params -PreactNativeArchitectures=arm64-v8a,x86_64'
+          rock-build-extra-params: '--extra-params -PreactNativeArchitectures=arm64-v8a,x86_64'
           comment-bot: false

.github/workflows/remote-build-ios.yml

@@ -51,10 +51,10 @@ jobs:
           git fetch origin pull/${{ github.event.inputs.mobile_expensify_pr }}/head:pr-${{ github.event.inputs.mobile_expensify_pr }}
           git checkout pr-${{ github.event.inputs.mobile_expensify_pr }}
           echo "Checked out Mobile-Expensify PR #${{ github.event.inputs.mobile_expensify_pr }}"
-
-      - name: RNEF Remote Build - iOS
-        # rnef v2
-        uses: callstackincubator/ios@7847e0676242cefa801cba8ede6736140b7bae91 
+          
+      - name: Rock Remote Build - iOS
+        # rock v3
+        uses: callstackincubator/ios@08a533dbeda6adec39f94d08d820091514d1f7af
         env:
           GITHUB_TOKEN: ${{ github.token }}
           IS_HYBRID_APP: ${{ matrix.is_hybrid_build }}

.gitignore

@@ -148,8 +148,8 @@ docs/.bundle
 # Output of react compiler healthcheck dev script
 react-compiler-output.txt
 
-# React Native Enterprise Framework
-.rnef/
+# Rock Framework
+.rock/
 
 # Generated by bob (for Nitro modules)
 modules/*/lib/

.prettierignore

@@ -3,7 +3,7 @@
 .well-known
 desktop/dist/**/*.js
 dist/**/*.js
-.rnef
+.rock
 assets/animations
 android
 ios

README.md

@@ -182,7 +182,7 @@ variables referenced here get updated since your local `.env` file is ignored.
 - `E2E_TESTING` (optional) - This needs to be set to `true` when running the e2e tests for performance regression testing.
    This happens usually automatically, read [this](tests/e2e/README.md) for more information
 
-> If your changes to .env aren't having an effect, try `rm -rf .rnef`, then re-run `npm run ios` or `npm run android`
+> If your changes to .env aren't having an effect, try `rm -rf .rock`, then re-run `npm run ios` or `npm run android`
 
 ----
 

android/app/build.gradle

@@ -66,7 +66,7 @@ react {
     autolinkLibrariesWithApp()
     // Added by install-expo-modules
     entryFile = file(["node", "-e", "require('expo/scripts/resolveAppEntry')", rootDir.getAbsoluteFile().getParentFile().getAbsolutePath(), "android", "absolute"].execute(null, rootDir).text.trim())
-    cliFile = file("../../node_modules/@rnef/cli/dist/src/bin.js")
+    cliFile = file("../../node_modules/rock/dist/src/bin.js")
     bundleCommand = "bundle"
 }
 

android/settings.gradle

@@ -2,7 +2,7 @@ pluginManagement { includeBuild("../node_modules/@react-native/gradle-plugin") }
 plugins { id("com.facebook.react.settings") }
 apply from: "${rootDir}/../gradleUtils/PatchedArtifactsSettings.gradle"
 
-extensions.configure(com.facebook.react.ReactSettingsExtension){ ex -> ex.autolinkLibrariesFromCommand(['npx', 'rnef', 'config', '-p', 'android']) }
+extensions.configure(com.facebook.react.ReactSettingsExtension){ ex -> ex.autolinkLibrariesFromCommand(['npx', 'rock', 'config', '-p', 'android']) }
 rootProject.name = 'NewExpensify'
 include ':react-native-webview'
 project(':react-native-webview').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-webview/android')

cspell.json

@@ -548,7 +548,7 @@
         "retryable",
         "Reupholstery",
         "rideshare",
-        "rnef",
+        "rock",
         "RNFS",
         "rnmapbox",
         "RNTL",

ios/Podfile

@@ -82,7 +82,7 @@ target 'NewExpensify' do
     'ReleaseProduction' => :release,
     'Debug' => :debug
 
-  config = use_native_modules!(['npx', 'rnef', 'config', '-p', 'ios'])
+  config = use_native_modules!(['npx', 'rock', 'config', '-p', 'ios'])
 
   # Flags change depending on the env values.
   flags = get_default_flags()