Remove lint suppression

Author: roryabraham

lib/useOnyx.ts

@@ -78,10 +78,13 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(
     const previousKey = usePrevious(key);
 
     const currentDependenciesRef = useLiveRef(dependencies);
+    const selector = options?.selector;
 
     // Create memoized version of selector for performance
     const memoizedSelector = useMemo(() => {
-        if (!options?.selector) return null;
+        if (!selector) {
+            return null;
+        }
 
         let lastInput: OnyxValue<TKey> | undefined;
         let lastOutput: TReturnValue;
@@ -95,8 +98,8 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(
             const dependenciesChanged = !shallowEqual(lastDependencies, currentDependencies);
             if (!hasComputed || lastInput !== input || dependenciesChanged) {
                 // Only proceed if we have a valid selector
-                if (options?.selector) {
-                    const newOutput = options.selector(input);
+                if (selector) {
+                    const newOutput = selector(input);
 
                     // Deep equality mode: only update if output actually changed
                     if (!hasComputed || !deepEqual(lastOutput, newOutput) || dependenciesChanged) {
@@ -110,8 +113,7 @@ function useOnyx<TKey extends OnyxKey, TReturnValue = OnyxValue<TKey>>(
 
             return lastOutput;
         };
-        // eslint-disable-next-line react-hooks/exhaustive-deps -- we only need options?.selector, not the entire options object
-    }, [currentDependenciesRef, options?.selector]);
+    }, [currentDependenciesRef, selector]);
 
     // Stores the previous cached value as it's necessary to compare with the new value in `getSnapshot()`.
     // We initialize it to `null` to simulate that we don't have any value from cache yet.