Merge pull request Expensify#659 from callstack-internal/fix/set-shared-object-reference

fix: shared object references in set() and removeNestedNullValues

Author: mountiny

lib/Onyx.ts

@@ -180,7 +180,7 @@ function set<TKey extends OnyxKey>(key: TKey, value: OnyxSetInput<TKey>, options
         return Promise.resolve();
     }
 
-    const valueWithoutNestedNullValues = (options?.skipNullRemoval ? value : utils.removeNestedNullValues(value)) as OnyxValue<TKey>;
+    const valueWithoutNestedNullValues = (options?.skipNullRemoval ? {...value} : utils.removeNestedNullValues(value)) as OnyxValue<TKey>;
     const hasChanged = options?.skipCacheCheck ? true : cache.hasValueChanged(key, valueWithoutNestedNullValues);
 
     OnyxUtils.logKeyChanged(OnyxUtils.METHOD.SET, key, value, hasChanged);

lib/utils.ts

@@ -172,12 +172,12 @@ function isMergeableObject<TObject extends Record<string, unknown>>(value: unkno
 
 /** Deep removes the nested null values from the given value. */
 function removeNestedNullValues<TValue extends OnyxInput<OnyxKey> | null>(value: TValue): TValue {
-    if (value === null || value === undefined) {
+    if (value === null || value === undefined || typeof value !== 'object') {
         return value;
     }
 
-    if (typeof value !== 'object' || Array.isArray(value)) {
-        return value;
+    if (Array.isArray(value)) {
+        return [...value] as TValue;
     }
 
     const result: Record<string, unknown> = {};