fix: remove tab bar icon workaround

Author: okwasniewski

packages/react-navigation/src/types.ts

@@ -67,12 +67,6 @@ export type NativeBottomTabNavigationOptions = {
    */
   tabBarIcon?: (props: { focused: boolean }) => ImageSourcePropType | AppleIcon;
 
-  /**
-   * Whether the tab bar item is visible when this screen is active.
-   * Used for compatibility with JS Tabs. Prefer using `tabBarItemHidden` as this API may be removed in the future.
-   */
-  tabBarButton?: () => null;
-
   /**
    * Whether the tab bar item is visible. Defaults to true.
    */

packages/react-navigation/src/views/NativeBottomTabView.tsx

@@ -42,11 +42,7 @@ export default function NativeBottomTabView({
       getBadge={({ route }) => descriptors[route.key]?.options.tabBarBadge}
       getHidden={({ route }) => {
         const options = descriptors[route.key]?.options;
-
-        return (
-          options?.tabBarItemHidden === true ||
-          options?.tabBarButton?.() === null
-        );
+        return options?.tabBarItemHidden === true;
       }}
       getIcon={({ route, focused }) => {
         const options = descriptors[route.key]?.options;