Commit 2327dfd
committed
fix(android): add missing badgeBackgroundColor and badgeTextColor to TabInfo
The TabInfo data class was missing badgeBackgroundColor and badgeTextColor
properties that RCTTabView.kt expects when applying badge colors.
This caused Android builds to fail with:
- Unresolved reference 'badgeBackgroundColor'
- Unresolved reference 'badgeTextColor'
- Unresolved reference 'colorError'
Changes:
- Add badgeBackgroundColor and badgeTextColor properties to TabInfo data class
- Populate them from JS bridge in setItems()
- Simplify badge color application to let Material use default theme colors
when custom colors are not provided (avoids colorError resolution issues)
Fixes #4811 parent 3a21e31 commit 2327dfd
File tree
2 files changed
+7
-25
lines changed- packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview
2 files changed
+7
-25
lines changedLines changed: 3 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
256 | 256 | | |
257 | 257 | | |
258 | 258 | | |
259 | | - | |
260 | | - | |
261 | | - | |
262 | | - | |
263 | | - | |
264 | | - | |
265 | | - | |
266 | | - | |
267 | | - | |
268 | | - | |
269 | | - | |
270 | | - | |
271 | | - | |
272 | | - | |
273 | | - | |
274 | | - | |
275 | | - | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | | - | |
280 | | - | |
281 | | - | |
282 | | - | |
283 | | - | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
284 | 262 | | |
285 | 263 | | |
286 | 264 | | |
| |||
Lines changed: 4 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
| 24 | + | |
| 25 | + | |
24 | 26 | | |
25 | 27 | | |
26 | 28 | | |
| |||
99 | 101 | | |
100 | 102 | | |
101 | 103 | | |
| 104 | + | |
| 105 | + | |
102 | 106 | | |
103 | 107 | | |
104 | 108 | | |
| |||
0 commit comments