fix: shutdown ImageLoader onDropViewInstance on android (#311)

* fix: shutdown ImageLoader when onDropViewInstance

* Create lucky-dots-cheat.md

---------

Co-authored-by: Oskar Kwaśniewski <[email protected]>

Author: johankasperi

.changeset/lucky-dots-cheat.md

@@ -0,0 +1,5 @@
+---
+"react-native-bottom-tabs": patch
+---
+
+fix: propery destroy image loader on Android

packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt

@@ -384,6 +384,10 @@ class ReactBottomNavigationView(context: Context) : LinearLayout(context) {
     updateTextAppearance()
   }
 
+  fun onDropViewInstance() {
+    imageLoader.shutdown()
+  }
+
   private fun updateTextAppearance() {
     if (fontSize != null || fontFamily != null || fontWeight != null) {
       val menuView = bottomNavigation.getChildAt(0) as? ViewGroup ?: return
@@ -455,9 +459,4 @@ class ReactBottomNavigationView(context: Context) : LinearLayout(context) {
     updateItems(items)
     uiModeConfiguration = newConfig?.uiMode ?: uiModeConfiguration
   }
-
-  override fun onDetachedFromWindow() {
-    super.onDetachedFromWindow()
-    imageLoader.shutdown()
-  }
 }

packages/react-native-bottom-tabs/android/src/newarch/RCTTabViewManager.kt

@@ -43,6 +43,11 @@ class RCTTabViewManager(context: ReactApplicationContext) :
 
   }
 
+  override fun onDropViewInstance(view: ReactBottomNavigationView) {
+    super.onDropViewInstance(view)
+    view.onDropViewInstance()
+  }
+
   override fun getName(): String {
     return tabViewImpl.getName()
   }

packages/react-native-bottom-tabs/android/src/oldarch/RCTTabViewManager.kt

@@ -39,6 +39,11 @@ class RCTTabViewManager(context: ReactApplicationContext) : ViewGroupManager<Rea
     return view
   }
 
+  override fun onDropViewInstance(view: ReactBottomNavigationView) {
+    super.onDropViewInstance(view)
+    view.onDropViewInstance()
+  }
+
   override fun getChildCount(parent: ReactBottomNavigationView): Int {
     return tabViewImpl.getChildCount(parent)
   }