Skip to content

Commit d02504c

Browse files
committed
chore: changes after latest review
1 parent 0e9d7a3 commit d02504c

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

docs/docs/docs/guides/standalone-usage.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ Color of tab indicator.
200200

201201
- Type: `ColorValue`
202202

203-
#### `renderBottomAccessoryView` <Badge text="iOS" type="info" />
203+
#### `renderBottomAccessoryView` <Badge text="iOS" type="info" /> <Badge text="experimental" type="danger"/>
204204

205205
Function that returns a React element to render as [bottom accessory](https://developer.apple.com/documentation/uikit/uitabbarcontroller/bottomaccessory).
206206

docs/docs/docs/guides/usage-with-react-navigation.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,7 @@ function MyTabs() {
216216
);
217217
}
218218
```
219-
#### `renderBottomAccessoryView` <Badge text="iOS" type="info" />
219+
#### `renderBottomAccessoryView` <Badge text="iOS" type="info" /> <Badge text="experimental" type="danger"/>
220220

221221
Function that returns a React element to render as [bottom accessory](https://developer.apple.com/documentation/uikit/uitabbarcontroller/bottomaccessory).
222222

packages/react-native-bottom-tabs/ios/RCTBottomAccessoryComponentView.mm

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,18 +45,14 @@ - (void)setFrame:(CGRect)frame
4545
[super setFrame:frame];
4646
auto eventEmitter = std::static_pointer_cast<const BottomAccessoryViewEventEmitter>(_eventEmitter);
4747
if (eventEmitter) {
48+
TODO: Rewrite this to emit synchronous layout events using shadow nodes
4849
eventEmitter->onNativeLayout(BottomAccessoryViewEventEmitter::OnNativeLayout {
4950
.height = frame.size.height,
5051
.width = frame.size.width
5152
});
5253
}
5354
}
5455

55-
- (void)updateProps:(Props::Shared const &)props oldProps:(Props::Shared const &)oldProps
56-
{
57-
[super updateProps:props oldProps:oldProps];
58-
}
59-
6056
// MARK: BottomAccessoryProviderDelegate
6157

6258
- (void)onPlacementChangedWithPlacement:(NSString *)placement

0 commit comments

Comments
 (0)