fix: use TabViewImpl to share code across architectures

Author: okwasniewski

packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabViewImpl.kt

@@ -1,6 +1,8 @@
 package com.rcttabview
 
 import android.content.res.ColorStateList
+import android.view.View
+import android.view.ViewGroup
 import com.facebook.react.bridge.ReadableArray
 import com.facebook.react.common.MapBuilder
 import com.rcttabview.events.OnNativeLayoutEvent
@@ -93,6 +95,36 @@ class RCTTabViewImpl {
     )
   }
 
+  fun getChildCount(parent: ReactBottomNavigationView): Int {
+    return parent.viewPagerAdapter.itemCount ?: 0
+  }
+
+  fun getChildAt(parent: ReactBottomNavigationView, index: Int): View? {
+    return parent.viewPagerAdapter.getChildAt(index)
+  }
+
+  fun removeView(parent: ReactBottomNavigationView, view: View) {
+    parent.viewPagerAdapter.removeChild(view)
+  }
+
+  fun removeAllViews(parent: ReactBottomNavigationView) {
+    parent.viewPagerAdapter.removeAll()
+  }
+
+  fun removeViewAt(parent: ReactBottomNavigationView, index: Int) {
+    val child = parent.viewPagerAdapter.getChildAt(index)
+
+    if (child.parent != null) {
+      (child.parent as? ViewGroup)?.removeView(child)
+    }
+
+    parent.viewPagerAdapter.removeChildAt(index)
+  }
+
+  fun needsCustomLayoutForChildren(): Boolean {
+    return true
+  }
+
   companion object {
     const val NAME = "RNCTabView"
   }

packages/react-native-bottom-tabs/android/src/newarch/RCTTabViewManager.kt

@@ -48,33 +48,27 @@ class RCTTabViewManager(context: ReactApplicationContext) :
   }
 
   override fun getChildCount(parent: ReactBottomNavigationView): Int {
-    return parent.viewPagerAdapter.itemCount ?: 0
+    return tabViewImpl.getChildCount(parent)
   }
 
   override fun getChildAt(parent: ReactBottomNavigationView, index: Int): View? {
-    return parent.viewPagerAdapter.getChildAt(index)
+    return tabViewImpl.getChildAt(parent, index)
   }
 
   override fun removeView(parent: ReactBottomNavigationView, view: View) {
-    parent.viewPagerAdapter.removeChild(view)
+    tabViewImpl.removeView(parent, view)
   }
 
   override fun removeAllViews(parent: ReactBottomNavigationView) {
-    parent.viewPagerAdapter.removeAll()
+    tabViewImpl.removeAllViews(parent)
   }
 
   override fun removeViewAt(parent: ReactBottomNavigationView, index: Int) {
-    val child = parent.viewPagerAdapter.getChildAt(index)
-
-    if (child.parent != null) {
-      (child.parent as? ViewGroup)?.removeView(child)
-    }
-
-    parent.viewPagerAdapter.removeChildAt(index)
+    tabViewImpl.removeViewAt(parent, index)
   }
 
   override fun needsCustomLayoutForChildren(): Boolean {
-    return true
+    return tabViewImpl.needsCustomLayoutForChildren()
   }
 
   override fun setItems(view: ReactBottomNavigationView?, value: ReadableArray?) {

packages/react-native-bottom-tabs/android/src/oldarch/RCTTabViewManager.kt

@@ -41,33 +41,27 @@ class RCTTabViewManager(context: ReactApplicationContext) : ViewGroupManager<Rea
   }
 
   override fun getChildCount(parent: ReactBottomNavigationView): Int {
-    return parent.viewPagerAdapter.itemCount ?: 0
+    return tabViewImpl.getChildCount(parent)
   }
 
   override fun getChildAt(parent: ReactBottomNavigationView, index: Int): View? {
-    return parent.viewPagerAdapter.getChildAt(index)
+    return tabViewImpl.getChildAt(parent, index)
   }
 
   override fun removeView(parent: ReactBottomNavigationView, view: View) {
-    parent.viewPagerAdapter.removeChild(view)
+    tabViewImpl.removeView(parent, view)
   }
 
   override fun removeAllViews(parent: ReactBottomNavigationView) {
-   parent.viewPagerAdapter.removeAll()
+    tabViewImpl.removeAllViews(parent)
   }
 
   override fun removeViewAt(parent: ReactBottomNavigationView, index: Int) {
-    val child = parent.viewPagerAdapter.getChildAt(index)
-
-    if (child.parent != null) {
-      (child.parent as? ViewGroup)?.removeView(child)
-    }
-
-    parent.viewPagerAdapter.removeChildAt(index)
+    tabViewImpl.removeViewAt(parent, index)
   }
 
   override fun needsCustomLayoutForChildren(): Boolean {
-    return true
+    return tabViewImpl.needsCustomLayoutForChildren()
   }
 
   override fun getExportedCustomDirectEventTypeConstants(): MutableMap<String, Any>? {