Dynamic tabBarIcon stops working on Android when opening a modal if tab hasn't been previously focused

[johankasperi]

Before submitting a new issue

• I tested using the latest version of the library, as the bug might be already fixed.
• I tested using a supported version of react native.
• I checked for possible duplicate issues, with possible answers.

Bug summary

Once again, thank you for an awesome library! Really appreciate the work you put in and its amazing how fast you respond and fixes issues.

Seems like #304 didn't fix #298 completely because tabs do not change their icon based on focused after opening a modal if the tab has not previously been focused.

android-modal-tabs-bug-2.mov

Library version

3.8.7

Environment info

System:
  OS: macOS 15.3.1
  CPU: (10) arm64 Apple M1 Pro
  Memory: 260.52 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 20.17.0
    path: ~/.nvm/versions/node/v20.17.0/bin/node
  Yarn:
    version: 4.6.0
    path: ~/.nvm/versions/node/v20.17.0/bin/yarn
  npm:
    version: 10.8.2
    path: ~/.nvm/versions/node/v20.17.0/bin/npm
  Watchman:
    version: 2024.12.02.00
    path: /opt/homebrew/bin/watchman
Managers:
  CocoaPods:
    version: 1.15.2
    path: /Users/johan.kasperi/.rbenv/shims/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 24.1
      - iOS 18.1
      - macOS 15.1
      - tvOS 18.1
      - visionOS 2.1
      - watchOS 11.1
  Android SDK:
    API Levels:
      - "28"
      - "30"
      - "34"
      - "35"
    Build Tools:
      - 28.0.3
      - 29.0.2
      - 29.0.3
      - 30.0.2
      - 30.0.3
      - 31.0.0
      - 32.0.0
      - 33.0.0
      - 33.0.0
      - 33.0.1
      - 34.0.0
      - 34.0.0
      - 35.0.0
    System Images:
      - android-22 | Google APIs ARM 64 v8a
      - android-23 | Google APIs ARM 64 v8a
      - android-25 | Google APIs ARM 64 v8a
      - android-28 | Google ARM64-V8a Play ARM 64 v8a
      - android-35 | Google APIs ARM 64 v8a
      - android-VanillaIceCream | Google Play ARM 64 v8a
    Android NDK: Not Found
IDEs:
  Android Studio: 2024.2 AI-242.23339.11.2421.12483815
  Xcode:
    version: 16.1/16B40
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 17.0.5
    path: /Users/johan.kasperi/.sdkman/candidates/java/current/bin/javac
  Ruby:
    version: 2.7.5
    path: /Users/johan.kasperi/.rbenv/shims/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: false
  newArchEnabled: true
iOS:
  hermesEnabled: false
  newArchEnabled: false

Steps to reproduce

1. Clone https://github.com/johankasperi/react-native-bottom-tabs/tree/android-modal-tabbaricon-bug
2. Run example app on Android
3. Open "Embedded stacks"

Reproducible sample code

https://github.com/johankasperi/react-native-bottom-tabs/tree/android-modal-tabbaricon-bug

[okwasniewski]

Oops! Sorry looks like I didn't test it properly. Will look into this again

[johankasperi]

Oops! Sorry looks like I didn't test it properly. Will look into this again

Thanks!

[johankasperi]

Found the reason for why this bug occurs. onDetachedFromWindow is called when opening a modal and the ImageLoader gets shutdown https://github.com/callstackincubator/react-native-bottom-tabs/blob/e5bb7126f771dbce497c45e32ed79b4007c37d26/packages/react-native-bottom-tabs/android/src/main/java/com/rcttabview/RCTTabView.kt#L461

Looking into how we can solve it but unsure

[johankasperi]

Opened a PR with my suggestion on how to fix #311