feat: measure custom tab bar #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment.
Pull Request Overview
This PR implements custom tab bar height measurement to ensure that useBottomTabBarHeight returns the correct value when a custom tab bar is provided.
- Adds a ref (customTabBarWrapperRef) and a useLayoutEffect hook to measure the tab bar height.
- Wraps the custom tab bar rendering in a View with the ref to facilitate measurement.
okwasniewski
force-pushed
the
feat/measure-custom-tab-bar
branch
from
4fc116b to
d6f05c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR implements measuring of custom tab bar so it's properly returned in
useBottomTabBarHeight().How to test?
Check if useBottomTabBarHeight is not 0 if passed a custom tab bar.