-
Notifications
You must be signed in to change notification settings - Fork 26
Open
Labels
questionFurther information is requestedFurther information is requested
Description
Hey correct me if im wrong but this lazy property isnt used
react-native-brownfield/ios/ReactNativeBrownfield.swift
Lines 75 to 97 in 078618f
lazy private var rootViewFactory: RCTRootViewFactory? = { | |
return reactNativeFactory?.rootViewFactory | |
}() | |
/** | |
* Starts React Native with default parameters. | |
*/ | |
@objc public func startReactNative() { | |
startReactNative(onBundleLoaded: nil) | |
} | |
@objc public func view( | |
moduleName: String, | |
initialProps: [AnyHashable: Any]?, | |
launchOptions: [AnyHashable: Any]? = nil | |
) -> UIView? { | |
reactNativeFactory?.rootViewFactory.view( | |
withModuleName: moduleName, | |
initialProperties: initialProps, | |
launchOptions: launchOptions | |
) | |
} | |
shouldnt it be like
@objc public func view(
moduleName: String,
initialProps: [AnyHashable: Any]?,
launchOptions: [AnyHashable: Any]? = nil
) -> UIView? {
rootViewFactory?.view(
withModuleName: moduleName,
initialProperties: initialProps,
launchOptions: launchOptions
)
}
Metadata
Metadata
Assignees
Labels
questionFurther information is requestedFurther information is requested