feat: remove cwd

Author: atlj

docs/pages/build.md

@@ -194,15 +194,11 @@ Define a custom build target. This is useful to call code generators during the
 
 ##### `script`
 
-`bob` will run the script passed in the `script` option. The build process **will throw and exit** if the `build` target is defined without this option.
-
-##### `cwd`
-
-You can set the `cwd` (current working directory) option to specify where the command should be called from. This option accepts **a relative path**, and it will default to the path `build` was called from.
+Accepts a script name. `bob` will call the matching script defined under `package.json`'s `scripts` property. The build process **will throw and exit** if the target is defined without this option.
 
 ##### `clean`
 
-You can pass a path to this option and `bob` will delete all the files on that path. The path is resolved relatively to the `cwd` option.
+You can pass a path to this option and `bob` will delete all the files on that path. The path is resolved relatively to where `build` was called from.
 
 #### `commonjs`
 

packages/react-native-builder-bob/src/index.ts

@@ -592,7 +592,7 @@ async function buildTarget(
         output: path.resolve(root, output, 'typescript'),
         report,
         root,
-      })
+      });
       break;
     default:
       logger.exit(`Invalid target ${kleur.blue(targetName)}.`);

packages/react-native-builder-bob/src/targets/custom.ts

@@ -8,57 +8,50 @@ import del from 'del';
 type Options = Input & {
   options?: {
     script?: string;
-    cwd?: string;
     clean?: string;
-  }
+  };
 };
 
-const NO_SCRIPT_ERROR_MESSAGE = dedent(
-  `No script provided with the custom target.
-         Example: ${kleur.green('{["custom", { "script": "yarn generateTypes" }}')}`
-)
-
-export default async function customTarget({
-  options,
-  root,
-  report
-}: Options) {
+export default async function customTarget({ options, root, report }: Options) {
   if (options?.script === undefined) {
     report.error(
-      NO_SCRIPT_ERROR_MESSAGE
-    )
-    process.exit(1)
-  }
-
-  const [scriptBinary, ...scriptParams] = options.script.split(" ");
-  if (scriptBinary === undefined) {
-    report.error(
-      NO_SCRIPT_ERROR_MESSAGE
-    )
-    process.exit(1)
-  }
-
-  let cwd = root
-  if (options.cwd) {
-    cwd = path.resolve(root, options.cwd)
+      dedent(
+        `No script was provided with the custom target.
+         Example: ${kleur.green('{["custom", { "script": "generateTypes" }}')}`
+      )
+    );
+    process.exit(1);
   }
 
   if (options.clean) {
     report.info(
-      `Cleaning up previous custom build at ${kleur.blue(path.relative(root, options.clean))}`
+      `Cleaning up previous custom build at ${kleur.blue(
+        path.relative(root, options.clean)
+      )}`
     );
 
-    await del([path.resolve(cwd, options.clean)])
+    await del([path.resolve(root, options.clean)]);
   }
 
+  const packageManager = process.env.npm_execpath ?? 'npm';
+  const packageManagerArgs = ['run', options.script];
 
+  // usr/bin/yarn -> yarn
+  const packageManagerName = path.basename(packageManager);
   report.info(
-    `Running ${kleur.blue(options.script)} `
+    `Calling ${kleur.blue(packageManagerName)} ${kleur.blue(
+      packageManagerArgs.join(' ')
+    )}`
   );
 
-  await spawn(scriptBinary, scriptParams, {
-    cwd,
-  })
+  try {
+    await spawn(packageManager, packageManagerArgs, {
+      stdio: ['ignore', 'ignore', 'inherit'],
+    });
+  } catch (e) {
+    report.error(`Couldn't run ${kleur.blue(options.script)} script`);
+    process.exit(1);
+  }
 
-  report.success(`Ran ${kleur.blue(options.script)} succesfully`)
+  report.success(`Ran ${kleur.blue(options.script)} script succesfully`);
 }

packages/react-native-builder-bob/src/types.ts

@@ -13,7 +13,12 @@ export type Input = {
   report: Report;
 };
 
-export type Target = 'commonjs' | 'module' | 'typescript' | 'codegen' | 'custom';
+export type Target =
+  | 'commonjs'
+  | 'module'
+  | 'typescript'
+  | 'codegen'
+  | 'custom';
 
 export type Options = {
   source?: string;