Skip to content

Commit 2f53830

Browse files
committed
refactor: fix type errors
1 parent ac0e2f7 commit 2f53830

File tree

2 files changed

+11
-23
lines changed

2 files changed

+11
-23
lines changed

packages/create-react-native-library/src/index.ts

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -416,16 +416,21 @@ async function create(argv: yargs.Arguments<any>) {
416416
};
417417

418418
await fs.mkdirp(folder);
419+
420+
const spinner = ora('Generating example app').start();
421+
419422
if (example === 'native') {
420-
const spinner = ora('Generating example app').start();
421423
await generateRNApp({
422424
dest: folder,
423425
projectName: options.project.name,
424426
isNewArch: options.project.turbomodule,
425427
});
426-
spinner.succeed();
427428
}
428429

430+
spinner.succeed(
431+
`Project created successfully at ${kleur.yellow(argv.name)}!\n`
432+
);
433+
429434
await copyDir(COMMON_FILES, folder);
430435

431436
if (languages === 'js') {
@@ -517,8 +522,6 @@ async function create(argv: yargs.Arguments<any>) {
517522

518523
console.log(
519524
dedent(`
520-
Project created successfully at ${kleur.yellow(argv.name)}!
521-
522525
${kleur.magenta(
523526
`${kleur.bold('Get started')} with the project`
524527
)}${kleur.gray(':')}

packages/create-react-native-library/src/utils/generateRNApp.ts

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import fs from 'fs';
1+
import fs from 'fs-extra';
22
import spawn from 'cross-spawn';
33
import path from 'path';
44

@@ -58,24 +58,9 @@ export default async function generateRNApp({
5858
createRNAppProcess.once('close', resolve);
5959
});
6060

61-
// Remove unnecessary files
62-
FILES_TO_DELETE.forEach((file) => {
63-
try {
64-
fs.unlinkSync(path.join(dest, 'example', file));
65-
} catch (e) {
66-
//ignore
67-
}
68-
});
69-
70-
// Remove unnecessary folders
71-
FOLDERS_TO_DELETE.forEach((folder) => {
72-
try {
73-
fs.rmSync(path.join(dest, 'example', folder), {
74-
recursive: true,
75-
});
76-
} catch (e) {
77-
// ignore
78-
}
61+
// Remove unnecessary files and folders
62+
[...FILES_TO_DELETE, ...FOLDERS_TO_DELETE].forEach((file) => {
63+
fs.removeSync(path.join(dest, 'example', file));
7964
});
8065

8166
// Patch the example app's package.json

0 commit comments

Comments
 (0)