refactor: drop old arch and cpp templates

the large number of templates makes it difficult to maintain and test.
so this reduces the number of templates:

- drop old architecture templates - users can use codegen or older
  version of crnl
- drop cpp templates - our cpp template isn't a pure cpp template, we
  should eventually have it

Author: satya164

.github/workflows/build-templates.yml

@@ -29,30 +29,15 @@ jobs:
         os:
           - ubuntu
           - macos
-        type:
-          - turbo-module
-          - fabric-view
-          - legacy-module
-          - legacy-view
-          - nitro-module
-        language:
-          - kotlin-objc
-          - kotlin-swift
-          - cpp
-        exclude:
+        type: []
+        language: []
+        include:
           - type: turbo-module
-            language: kotlin-swift
-          - type: fabric-view
-            language: kotlin-swift
+            language: kotlin-objc
           - type: fabric-view
-            language: cpp
-          - type: legacy-view
-            language: cpp
-          - type: nitro-module
             language: kotlin-objc
           - type: nitro-module
-            language: cpp
-        include:
+            language: kotlin-swift
           - os: ubuntu
             type: library
             language: js

docs/pages/create.md

@@ -29,6 +29,8 @@ This will ask you a few questions about your project and generate a new project
 
 After the project is created, you can find the development workflow in the generated `CONTRIBUTING.md` file.
 
+> Note: If you want to create a library using the legacy native modules and view APIs instead of the new architecture, you can use the `0.49.8` version of `create-react-native-library`: `npx [email protected] awesome-library`.
+
 ## Local library
 
 While the default templates are for libraries that are published to npm, you can also create a local library that is not published but used locally in your app.

packages/create-react-native-library/src/exampleApp/generateExampleApp.ts

@@ -261,39 +261,33 @@ export default async function generateExampleApp({
       'android.enableJetifier=false'
     );
 
-    // If the library is on new architecture, enable new arch for iOS and Android
-    if (config.project.arch === 'new') {
-      // iOS
-      // Add ENV['RCT_NEW_ARCH_ENABLED'] = 1 on top of example/ios/Podfile
-      const podfile = await fs.readFile(
-        path.join(directory, 'ios', 'Podfile'),
-        'utf8'
-      );
+    // Enable new arch for iOS and Android
+    // iOS
+    // Add ENV['RCT_NEW_ARCH_ENABLED'] = 1 on top of example/ios/Podfile
+    const podfile = await fs.readFile(
+      path.join(directory, 'ios', 'Podfile'),
+      'utf8'
+    );
 
-      await fs.writeFile(
-        path.join(directory, 'ios', 'Podfile'),
-        "ENV['RCT_NEW_ARCH_ENABLED'] = '1'\n\n" + podfile
-      );
+    await fs.writeFile(
+      path.join(directory, 'ios', 'Podfile'),
+      "ENV['RCT_NEW_ARCH_ENABLED'] = '1'\n\n" + podfile
+    );
 
-      // Android
-      // Make sure newArchEnabled=true is present in android/gradle.properties
-      if (gradleProperties.split('\n').includes('#newArchEnabled=true')) {
-        gradleProperties = gradleProperties.replace(
-          '#newArchEnabled=true',
-          'newArchEnabled=true'
-        );
-      } else if (
-        gradleProperties.split('\n').includes('newArchEnabled=false')
-      ) {
-        gradleProperties = gradleProperties.replace(
-          'newArchEnabled=false',
-          'newArchEnabled=true'
-        );
-      } else if (
-        !gradleProperties.split('\n').includes('newArchEnabled=true')
-      ) {
-        gradleProperties += '\nnewArchEnabled=true';
-      }
+    // Android
+    // Make sure newArchEnabled=true is present in android/gradle.properties
+    if (gradleProperties.split('\n').includes('#newArchEnabled=true')) {
+      gradleProperties = gradleProperties.replace(
+        '#newArchEnabled=true',
+        'newArchEnabled=true'
+      );
+    } else if (gradleProperties.split('\n').includes('newArchEnabled=false')) {
+      gradleProperties = gradleProperties.replace(
+        'newArchEnabled=false',
+        'newArchEnabled=true'
+      );
+    } else if (!gradleProperties.split('\n').includes('newArchEnabled=true')) {
+      gradleProperties += '\nnewArchEnabled=true';
     }
 
     await fs.writeFile(

packages/create-react-native-library/src/input.ts

@@ -18,13 +18,11 @@ export type ArgName =
   | 'example'
   | 'reactNativeVersion';
 
-export type ProjectLanguages = 'kotlin-objc' | 'kotlin-swift' | 'cpp' | 'js';
+export type ProjectLanguages = 'kotlin-objc' | 'kotlin-swift' | 'js';
 
 export type ProjectType =
   | 'turbo-module'
   | 'fabric-view'
-  | 'legacy-module'
-  | 'legacy-view'
   | 'nitro-module'
   | 'library';
 
@@ -36,17 +34,12 @@ const LANGUAGE_CHOICES: {
   {
     title: 'Kotlin & Swift',
     value: 'kotlin-swift',
-    types: ['nitro-module', 'legacy-module', 'legacy-view'],
+    types: ['nitro-module'],
   },
   {
     title: 'Kotlin & Objective-C',
     value: 'kotlin-objc',
-    types: ['turbo-module', 'fabric-view', 'legacy-module', 'legacy-view'],
-  },
-  {
-    title: 'C++ for Android & iOS',
-    value: 'cpp',
-    types: ['turbo-module', 'legacy-module'],
+    types: ['turbo-module', 'fabric-view'],
   },
   {
     title: 'JavaScript for Android, iOS & Web',
@@ -101,16 +94,6 @@ const TYPE_CHOICES: {
     description:
       'type-safe, fast integration for native APIs to JS (experimental)',
   },
-  {
-    title: 'Legacy Native module',
-    value: 'legacy-module',
-    description: 'bridge for native APIs to JS (old architecture)',
-  },
-  {
-    title: 'Legacy Native view',
-    value: 'legacy-view',
-    description: 'bridge for native views to JS (old architecture)',
-  },
   {
     title: 'JavaScript library',
     value: 'library',
@@ -167,7 +150,6 @@ export const acceptedArgs: Record<ArgName, yargs.Options> = {
 } as const;
 
 export type Args = Record<ArgName | 'name', string>;
-export type SupportedArchitecture = 'new' | 'legacy';
 export type ExampleApp = 'none' | 'test-app' | 'expo' | 'vanilla';
 
 export type Answers = {

packages/create-react-native-library/src/template.ts

@@ -1,12 +1,7 @@
 import path from 'path';
 import fs from 'fs-extra';
 import ejs from 'ejs';
-import type {
-  Answers,
-  ExampleApp,
-  ProjectType,
-  SupportedArchitecture,
-} from './input';
+import type { Answers, ExampleApp, ProjectType } from './input';
 
 export type TemplateVersions = {
   bob: string;
@@ -35,8 +30,6 @@ export type TemplateConfiguration = {
     package_cpp: string;
     identifier: string;
     native: boolean;
-    arch: SupportedArchitecture;
-    cpp: boolean;
     swift: boolean;
     viewConfig: ViewConfig;
     moduleConfig: ModuleConfig;
@@ -62,10 +55,6 @@ const EXAMPLE_COMMON_FILES = path.resolve(
   __dirname,
   '../templates/example-common'
 );
-const EXAMPLE_MODULE_LEGACY_FILES = path.resolve(
-  __dirname,
-  '../templates/example-module-legacy'
-);
 const EXAMPLE_MODULE_NEW_FILES = path.resolve(
   __dirname,
   '../templates/example-module-new'
@@ -74,7 +63,6 @@ const EXAMPLE_VIEW_FILES = path.resolve(__dirname, '../templates/example-view');
 
 const JS_FILES = path.resolve(__dirname, '../templates/js-library');
 const EXPO_FILES = path.resolve(__dirname, '../templates/expo-library');
-const CPP_FILES = path.resolve(__dirname, '../templates/cpp-library');
 const NATIVE_COMMON_FILES = path.resolve(
   __dirname,
   '../templates/native-common'
@@ -85,31 +73,21 @@ const NATIVE_COMMON_EXAMPLE_FILES = path.resolve(
 );
 
 const NATIVE_FILES = {
-  module_legacy: path.resolve(__dirname, '../templates/native-library-legacy'),
   module_new: path.resolve(__dirname, '../templates/native-library-new'),
-  view_legacy: path.resolve(__dirname, '../templates/native-view-legacy'),
   view_new: path.resolve(__dirname, '../templates/native-view-new'),
   module_nitro: path.resolve(__dirname, '../templates/nitro-module'),
 } as const;
 
 const OBJC_FILES = {
   module_common: path.resolve(__dirname, '../templates/objc-library'),
-  view_legacy: path.resolve(__dirname, '../templates/objc-view-legacy'),
   view_new: path.resolve(__dirname, '../templates/objc-view-new'),
 } as const;
 
 const KOTLIN_FILES = {
-  module_legacy: path.resolve(__dirname, '../templates/kotlin-library-legacy'),
   module_new: path.resolve(__dirname, '../templates/kotlin-library-new'),
-  view_legacy: path.resolve(__dirname, '../templates/kotlin-view-legacy'),
   view_new: path.resolve(__dirname, '../templates/kotlin-view-new'),
 } as const;
 
-const SWIFT_FILES = {
-  module_legacy: path.resolve(__dirname, '../templates/swift-library-legacy'),
-  view_legacy: path.resolve(__dirname, '../templates/swift-view-legacy'),
-} as const;
-
 export function generateTemplateConfiguration({
   versions,
   basename,
@@ -121,11 +99,6 @@ export function generateTemplateConfiguration({
 }): TemplateConfiguration {
   const { slug, languages, type } = answers;
 
-  const arch =
-    type === 'legacy-module' || type === 'legacy-view' || type === 'library'
-      ? 'legacy'
-      : 'new';
-
   const project = slug.replace(/^(react-native-|@[^/]+\/)/, '');
   let namespace: string | undefined;
 
@@ -159,8 +132,6 @@ export function generateTemplateConfiguration({
       package_cpp: pack.replace(/\./g, '_'),
       identifier: slug.replace(/[^a-z0-9]+/g, '-').replace(/^-/, ''),
       native: languages !== 'js',
-      arch,
-      cpp: languages === 'cpp',
       swift: languages === 'kotlin-swift',
       viewConfig: getViewConfig(type),
       moduleConfig: getModuleConfig(type),
@@ -182,17 +153,13 @@ function getModuleConfig(projectType: ProjectType): ModuleConfig {
       return 'nitro-modules';
     case 'turbo-module':
       return 'turbo-modules';
-    case 'legacy-module':
-      return 'native-modules';
     default:
       return null;
   }
 }
 
 function getViewConfig(projectType: ProjectType): ViewConfig {
   switch (projectType) {
-    case 'legacy-view':
-      return 'paper-view';
     case 'fabric-view':
       return 'fabric-view';
     default:
@@ -217,11 +184,7 @@ export async function applyTemplates(
       if (config.project.viewConfig !== null) {
         await applyTemplate(config, EXAMPLE_VIEW_FILES, folder);
       } else {
-        if (config.project.arch === 'legacy') {
-          await applyTemplate(config, EXAMPLE_MODULE_LEGACY_FILES, folder);
-        } else {
-          await applyTemplate(config, EXAMPLE_MODULE_NEW_FILES, folder);
-        }
+        await applyTemplate(config, EXAMPLE_MODULE_NEW_FILES, folder);
       }
     }
   }
@@ -242,43 +205,22 @@ export async function applyTemplates(
     }
 
     if (config.project.moduleConfig !== null) {
-      await applyTemplate(
-        config,
-        NATIVE_FILES[`module_${config.project.arch}`],
-        folder
-      );
+      await applyTemplate(config, NATIVE_FILES[`module_new`], folder);
     } else {
-      await applyTemplate(
-        config,
-        NATIVE_FILES[`view_${config.project.arch}`],
-        folder
-      );
+      await applyTemplate(config, NATIVE_FILES[`view_new`], folder);
     }
 
-    if (config.project.swift) {
-      await applyTemplate(config, SWIFT_FILES[`module_legacy`], folder);
+    if (config.project.moduleConfig !== null) {
+      await applyTemplate(config, OBJC_FILES[`module_common`], folder);
     } else {
-      if (config.project.moduleConfig !== null) {
-        await applyTemplate(config, OBJC_FILES[`module_common`], folder);
-      } else {
-        await applyTemplate(
-          config,
-          OBJC_FILES[`view_${config.project.arch}`],
-          folder
-        );
-      }
+      await applyTemplate(config, OBJC_FILES[`view_new`], folder);
     }
 
     const templateType = `${
       config.project.moduleConfig !== null ? 'module' : 'view'
-    }_${config.project.arch}` as const;
+    }_new` as const;
 
     await applyTemplate(config, KOTLIN_FILES[templateType], folder);
-
-    if (config.project.cpp) {
-      await applyTemplate(config, CPP_FILES, folder);
-      await fs.remove(path.join(folder, 'ios', `${config.project.name}.m`));
-    }
   }
 }
 

packages/create-react-native-library/templates/common-local/$package.json

@@ -3,13 +3,11 @@
   "version": "0.0.0",
   "description": "<%- project.description %>",
   "main": "src/index",
-<% if (project.arch === 'new') { -%>
   "codegenConfig": {
     "name": "RN<%- project.name -%><%- project.viewConfig !== null ? 'View': '' -%>Spec",
     "type": <%- project.viewConfig !== null ? '"all"': '"modules"' %>,
     "jsSrcsDir": "src"
   },
-<% } -%>
   "author": "<%- author.name -%> <<%- author.email -%>> (<%- author.url -%>)",
   "license": "UNLICENSED",
   "homepage": "<%- repo -%>#readme"

packages/create-react-native-library/templates/common/CONTRIBUTING.md

@@ -18,13 +18,14 @@ yarn
 ```
 
 > Since the project relies on Yarn workspaces, you cannot use [`npm`](https://github.com/npm/cli) for development.
-<% if (project.moduleConfig === 'nitro-modules') { -%>
+> <% if (project.moduleConfig === 'nitro-modules') { -%>
 
 This project uses Nitro Modules. If you're not familiar with how Nitro works, make sure to check the [Nitro Modules Docs](https://nitro.margelo.com/).
 
 You need to run [Nitrogen](https://nitro.margelo.com/docs/nitrogen) to generate the boilerplate code required for this project. The example app will not build without this step.
 
 Run **Nitrogen** in following cases:
+
 - When you make changes to any `*.nitro.ts` files.
 - When running the project for the first time (since the generated files are not committed to the repository).
 
@@ -33,6 +34,7 @@ To invoke **Nitrogen**, use the following command:
 ```sh
 yarn nitrogen
 ```
+
 <% } -%>
 
 The [example app](/example/) demonstrates usage of the library. You need to run it to test any changes you make.
@@ -65,7 +67,6 @@ To run the example app on iOS:
 yarn example ios
 ```
 
-<% if (project.arch === 'new') { -%>
 To confirm that the app is running with the new architecture, you can check the Metro logs for a message like this:
 
 ```sh
@@ -74,7 +75,6 @@ Running "<%- project.name -%>Example" with {"fabric":true,"initialProps":{"concu
 
 Note the `"fabric":true` and `"concurrentRoot":true` properties.
 
-<% } -%>
 <% if (!project.native) { -%>
 To run the example app on Web: