Commit 3846426
authored
fix: don't use deprecated package field in AndroidManifest on AGP >= 7.3 (#420)
### Summary
Follow-up to
#399
Currently there's a deprecation warning for the `package` field in
`AndroidManifest.xml` when using Android Gradle Plugin >= 7.3.
This adds a separate `AndroidManifest` file that'll be used for older
versions of Android Gradle Plugin to avoid the deprecation warning on
newer versions.
### Test plan
- Verify CI passes
- Verify building and running various templates1 parent 9189852 commit 3846426
File tree
3 files changed
+22
-7
lines changed- packages/create-react-native-library/templates/native-common/android
- src/main
3 files changed
+22
-7
lines changedLines changed: 18 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
67 | | - | |
68 | | - | |
69 | | - | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
70 | 78 | | |
71 | 79 | | |
72 | 80 | | |
73 | | - | |
| 81 | + | |
74 | 82 | | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
75 | 89 | | |
76 | 90 | | |
77 | 91 | | |
| |||
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
| 1 | + | |
4 | 2 | | |
Lines changed: 3 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
0 commit comments