refactor: properly type args

Author: atlj

packages/create-react-native-library/src/index.ts

@@ -15,14 +15,21 @@ import {
   createMetadata,
   type Answers,
   acceptedArgs,
+  type Args,
 } from './input';
 import { getDependencyVersionsFromExample } from './exampleApp/dependencies';
 import { printErrorHelp, printNextSteps } from './inform';
 
 const FALLBACK_BOB_VERSION = '0.32.0';
 
 yargs
-  .command('$0 [name]', 'create a react native library', acceptedArgs, create)
+  .command(
+    '$0 [name]',
+    'create a react native library',
+    acceptedArgs,
+    // @ts-expect-error Some types are still incompatible
+    create
+  )
   .demandCommand()
   .recommendCommands()
   .fail(printErrorHelp)
@@ -32,10 +39,7 @@ yargs
   })
   .strict().argv;
 
-// FIXME: fix the type
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-async function create(_argv: yargs.Arguments<any>) {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+async function create(_argv: yargs.Arguments<Args>) {
   const { _, $0, ...argv } = _argv;
 
   // Prefetch bob version in background while asking questions
@@ -155,7 +159,7 @@ async function create(_argv: yargs.Arguments<any>) {
   await printNextSteps(local, folder, config);
 }
 
-async function promptLocalLibrary(argv: Record<string, string>) {
+async function promptLocalLibrary(argv: Args) {
   let local = false;
 
   if (typeof argv.local === 'boolean') {
@@ -181,7 +185,7 @@ async function promptLocalLibrary(argv: Record<string, string>) {
   return local;
 }
 
-async function promptPath(argv: Record<string, string>, local: boolean) {
+async function promptPath(argv: Args, local: boolean) {
   let folder: string;
 
   if (argv.name && !local) {

packages/create-react-native-library/src/input.ts

@@ -8,15 +8,15 @@ import { spawn } from './utils/spawn';
 export type ArgName =
   | 'slug'
   | 'description'
-  | 'author-name'
-  | 'author-email'
-  | 'author-url'
-  | 'repo-url'
+  | 'authorName'
+  | 'authorEmail'
+  | 'authorUrl'
+  | 'repoUrl'
   | 'languages'
   | 'type'
   | 'local'
   | 'example'
-  | 'react-native-version';
+  | 'reactNativeVersion';
 
 export type ProjectLanguages = 'kotlin-objc' | 'kotlin-swift' | 'cpp' | 'js';
 
@@ -142,53 +142,54 @@ export type Question = Omit<
 };
 
 export const acceptedArgs: Record<ArgName, yargs.Options> = {
-  'slug': {
+  slug: {
     description: 'Name of the npm package',
     type: 'string',
   },
-  'description': {
+  description: {
     description: 'Description of the npm package',
     type: 'string',
   },
-  'author-name': {
+  authorName: {
     description: 'Name of the package author',
     type: 'string',
   },
-  'author-email': {
+  authorEmail: {
     description: 'Email address of the package author',
     type: 'string',
   },
-  'author-url': {
+  authorUrl: {
     description: 'URL for the package author',
     type: 'string',
   },
-  'repo-url': {
+  repoUrl: {
     description: 'URL for the repository',
     type: 'string',
   },
-  'languages': {
+  languages: {
     description: 'Languages you want to use',
     choices: LANGUAGE_CHOICES.map(({ value }) => value),
   },
-  'type': {
+  type: {
     description: 'Type of library you want to develop',
     choices: TYPE_CHOICES.map(({ value }) => value),
   },
-  'react-native-version': {
+  reactNativeVersion: {
     description: 'Version of React Native to use, uses latest if not specified',
     type: 'string',
   },
-  'local': {
+  local: {
     description: 'Whether to create a local library',
     type: 'boolean',
   },
-  'example': {
+  example: {
     description: 'Type of the example app to create',
     type: 'string',
     choices: EXAMPLE_CHOICES.map(({ value }) => value),
   },
-};
+} as const;
 
+export type Args = Record<ArgName | 'name', string>;
 export type SupportedArchitecture = 'new' | 'mixed' | 'legacy';
 export type ExampleApp = 'none' | 'test-app' | 'expo' | 'vanilla';
 
@@ -214,7 +215,7 @@ export async function createQuestions({
 }: {
   basename: string;
   local: boolean;
-  argv: Record<string, string>;
+  argv: Args;
 }) {
   let name, email;
 

packages/create-react-native-library/src/utils/assert.ts

@@ -1,6 +1,6 @@
 import kleur from 'kleur';
 import { spawn } from './spawn';
-import type { Answers, Question } from '../input';
+import type { Answers, Args, Question } from '../input';
 
 export async function assertNpx() {
   try {
@@ -24,7 +24,7 @@ export async function assertNpx() {
 /**
  * Makes sure the answers are in expected form and ends the process with error if they are not
  */
-export function assertAnswers(questions: Question[], answers: Answers) {
+export function assertAnswers(questions: Question[], answers: Answers | Args) {
   for (const [key, value] of Object.entries(answers)) {
     if (value == null) {
       continue;