fix: don't crash if resolving version fails

when creating a new library, it fails if resolving the version failed for some reason.
this is because the promise is created earlier, but the code with try catch is run way later.
this moves the promise into try/catch so it's properly handled.

Author: satya164

packages/create-react-native-library/src/index.ts

@@ -8,7 +8,7 @@ import generateExampleApp from './exampleApp/generateExampleApp';
 import { addCodegenBuildScript } from './exampleApp/addCodegenBuildScript';
 import { createInitialGitCommit } from './utils/initialCommit';
 import { assertUserInput, assertNpxExists } from './utils/assert';
-import { resolveBobVersionWithFallback } from './utils/promiseWithFallback';
+import { resolveNpmPackageVersion } from './utils/resolveNpmPackageVersion';
 import { applyTemplates, generateTemplateConfiguration } from './template';
 import {
   createQuestions,
@@ -44,7 +44,10 @@ async function create(_argv: yargs.Arguments<Args>) {
   const { _, $0, ...argv } = _argv;
 
   // Prefetch bob version in background while asking questions
-  const resolveBobVersion = resolveBobVersionWithFallback(FALLBACK_BOB_VERSION);
+  const bobVersionPromise = resolveNpmPackageVersion(
+    'react-native-builder-bob',
+    FALLBACK_BOB_VERSION
+  );
 
   const local = await promptLocalLibrary(argv);
   const folder = await promptPath(argv, local);
@@ -72,7 +75,7 @@ async function create(_argv: yargs.Arguments<Args>) {
 
   assertUserInput(questions, answers);
 
-  const bobVersion = await resolveBobVersion();
+  const bobVersion = await bobVersionPromise;
 
   const config = generateTemplateConfiguration({
     bobVersion,

packages/create-react-native-library/src/utils/promiseWithFallback.ts

@@ -0,0 +1,24 @@
+import { spawn } from './spawn';
+
+export async function resolveNpmPackageVersion(
+  name: string,
+  fallback: string,
+  timeout: number = 1000
+): Promise<string> {
+  let result: string;
+
+  try {
+    const promise = spawn('npm', ['view', name, 'dist-tags.latest']);
+
+    result = await Promise.race([
+      new Promise<string>((resolve) => {
+        setTimeout(() => resolve(fallback), timeout);
+      }),
+      promise,
+    ]);
+  } catch (e) {
+    result = fallback;
+  }
+
+  return result;
+}