Commit ace6101
authored
fix: use
### Summary
The React Native CLI relies on the filename `AndroidManifest.xml` to be
able parse the package name. But we were using
`AndroidManifestLegacy.xml` instead which broke the lib for older RN
versions (AGP 7). This change makes it so that we use
`AndroidManifest.xml` for older RN versions and `AndroidManifestNew.xml`
for newer RN versions.
Fixes #429
### Test plan
- Create an app with RN 0.68 and install the library without these
changes - see that `yarn android` fails
- Create an app with RN 0.68 and install the library with these changes
- see that `yarn android` succeeds
- Create an app with latest RN and install the library with these
changes - see that `yarn android` succeedsAndroidManifest.xml for older RN versions (#431)1 parent 44df3f9 commit ace6101
File tree
3 files changed
+5
-5
lines changed- packages/create-react-native-library/templates/native-common/android
- src/main
3 files changed
+5
-5
lines changedLines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
83 | | - | |
| 83 | + | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
| |||
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
| 1 | + | |
| 2 | + | |
2 | 3 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
| 1 | + | |
3 | 2 | | |
0 commit comments