Skip to content

Commit cbaecd2

Browse files
committed
refactor: simplify backward compatible fabric example for Android
1 parent 63321b9 commit cbaecd2

File tree

8 files changed

+84
-123
lines changed

8 files changed

+84
-123
lines changed

packages/create-react-native-library/templates/java-view-mixed/android/src/legacy/{%- project.name %}ViewManager.java

Lines changed: 0 additions & 38 deletions
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
package com.<%- project.package -%>;
2+
3+
import android.view.View;
4+
5+
import androidx.annotation.Nullable;
6+
7+
import com.facebook.react.bridge.ReactApplicationContext;
8+
import com.facebook.react.uimanager.SimpleViewManager;
9+
10+
public abstract class <%- project.name -%>ViewManagerSpec<T extends View> extends SimpleViewManager<T> {
11+
public <%- project.name -%>ViewManagerSpec(ReactApplicationContext context) {
12+
super();
13+
}
14+
15+
public abstract void setColor(T view, @Nullable String value);
16+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
package com.<%- project.package -%>;
2+
3+
import android.graphics.Color;
4+
5+
import androidx.annotation.Nullable;
6+
7+
import com.facebook.react.bridge.ReactApplicationContext;
8+
import com.facebook.react.module.annotations.ReactModule;
9+
import com.facebook.react.uimanager.ThemedReactContext;
10+
import com.facebook.react.uimanager.annotations.ReactProp;
11+
12+
@ReactModule(name = <%- project.name -%>ViewManager.NAME)
13+
public class <%- project.name -%>ViewManager extends <%- project.name -%>ViewManagerSpec<<%- project.name -%>View> {
14+
15+
public static final String NAME = "<%- project.name -%>View";
16+
17+
public <%- project.name -%>ViewManager(ReactApplicationContext reactContext) {
18+
super(reactContext);
19+
}
20+
21+
@Override
22+
public String getName() {
23+
return NAME;
24+
}
25+
26+
@Override
27+
public <%- project.name -%>View createViewInstance(ThemedReactContext context) {
28+
return new <%- project.name -%>View(context);
29+
}
30+
31+
@Override
32+
@ReactProp(name = "color")
33+
public void setColor(<%- project.name -%>View view, @Nullable String color) {
34+
view.setBackgroundColor(Color.parseColor(color));
35+
}
36+
}

packages/create-react-native-library/templates/java-view-mixed/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}ViewManagerImpl.java

Lines changed: 0 additions & 17 deletions
This file was deleted.

packages/create-react-native-library/templates/java-view-mixed/android/src/turbo/{%- project.name %}ViewManager.java

Lines changed: 0 additions & 43 deletions
This file was deleted.
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
package com.<%- project.package -%>;
2+
3+
import android.view.View;
4+
5+
import com.facebook.react.bridge.ReactApplicationContext;
6+
import com.facebook.react.uimanager.SimpleViewManager;
7+
import com.facebook.react.uimanager.ViewManagerDelegate;
8+
import com.facebook.react.viewmanagers.<%- project.name -%>ViewManagerDelegate;
9+
import com.facebook.react.viewmanagers.<%- project.name -%>ViewManagerInterface;
10+
11+
public abstract class <%- project.name -%>ViewManagerSpec<T extends View> extends SimpleViewManager<T> implements <%- project.name -%>ViewManagerInterface<T> {
12+
private final ViewManagerDelegate<T> mDelegate;
13+
14+
public <%- project.name -%>ViewManagerSpec(ReactApplicationContext context) {
15+
mDelegate = new <%- project.name -%>ViewManagerDelegate(this);
16+
}
17+
18+
@Override
19+
protected ViewManagerDelegate<T> getDelegate() {
20+
return mDelegate;
21+
}
22+
}
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.<%- project.package -%>;
22

3-
import com.facebook.react.bridge.ReadableArray;
3+
import android.graphics.Color;
4+
45
import com.facebook.react.module.annotations.ReactModule;
56
import com.facebook.react.uimanager.SimpleViewManager;
67
import com.facebook.react.uimanager.ThemedReactContext;
@@ -10,34 +11,35 @@
1011
import com.facebook.react.viewmanagers.<%- project.name -%>ViewManagerDelegate;
1112
import com.facebook.react.viewmanagers.<%- project.name -%>ViewManagerInterface;
1213

13-
import androidx.annotation.Nullable;
14-
15-
@ReactModule(name = <%- project.name -%>ViewManagerImpl.NAME)
14+
@ReactModule(name = <%- project.name -%>ViewManager.NAME)
1615
public class <%- project.name -%>ViewManager extends SimpleViewManager<<%- project.name -%>View> implements <%- project.name -%>ViewManagerInterface<<%- project.name -%>View> {
16+
17+
public static final String NAME = "<%- project.name -%>View";
18+
1719
private final ViewManagerDelegate<<%- project.name -%>View> mDelegate;
1820

1921
public <%- project.name -%>ViewManager(ReactApplicationContext context) {
2022
mDelegate = new <%- project.name -%>ViewManagerDelegate(this);
2123
}
2224

23-
@Nullable
2425
@Override
2526
protected ViewManagerDelegate<<%- project.name -%>View> getDelegate() {
2627
return mDelegate;
2728
}
2829

2930
@Override
3031
public String getName() {
31-
return <%- project.name -%>ViewManagerImpl.NAME;
32+
return NAME;
3233
}
3334

3435
@Override
3536
public <%- project.name -%>View createViewInstance(ThemedReactContext context) {
36-
return <%- project.name -%>ViewManagerImpl.createViewInstance(context);
37+
return new <%- project.name -%>View(context);
3738
}
3839

40+
@Override
3941
@ReactProp(name = "color")
4042
public void setColor(<%- project.name -%>View view, String color) {
41-
<%- project.name -%>ViewManagerImpl.setColor(view, color);
43+
view.setBackgroundColor(Color.parseColor(color));
4244
}
4345
}

packages/create-react-native-library/templates/java-view-new/android/src/main/java/com/{%- project.package_dir %}/{%- project.name %}ViewManagerImpl.java

Lines changed: 0 additions & 17 deletions
This file was deleted.

0 commit comments

Comments
 (0)