Commit d17ce35
authored
fix: js-only libraries have codegen config (#758)
### Summary
Fixes #754
JS-only libraries were setting the new architecture flag on. While this
is not a preferable mental modal, we had some code associated with
codegen that checked this flag. With this PR, JS-only libraries will set
this flag to false. This is not an optimal solution but we will fully
drop this flag with the deprecation of the legacy arch in the upcoming
months.
### Test plan
1. Generate a JavaScript-only library
1. Make sure the `codegen` target isn't added to bob targets in
`package.json`
1. Make sure there is no `codegenConfig` in `package.json`
1. Make sure `yarn prepare` works.1 parent c1b508a commit d17ce35
File tree
2 files changed
+12
-3
lines changed- packages/create-react-native-library
- src
- templates/example-module-legacy/example/src
2 files changed
+12
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
104 | 104 | | |
105 | 105 | | |
106 | 106 | | |
107 | | - | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
108 | 110 | | |
109 | 111 | | |
110 | 112 | | |
| |||
Lines changed: 9 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | 1 | | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
12 | 19 | | |
13 | 20 | | |
14 | 21 | | |
| |||
0 commit comments