fix: remove workaround for xcode 16.2

Author: Juozas-Petkelis

packages/create-react-native-library/src/constants.ts

@@ -1,3 +1,3 @@
 export const FALLBACK_BOB_VERSION = '0.40.8';
-export const FALLBACK_NITRO_MODULES_VERSION = '0.25.2';
+export const FALLBACK_NITRO_MODULES_VERSION = '0.26.2';
 export const SUPPORTED_REACT_NATIVE_VERSION = '0.79.2';

packages/create-react-native-library/src/exampleApp/generateExampleApp.ts

@@ -313,76 +313,6 @@ export default async function generateExampleApp({
       gradleProperties += '\nnewArchEnabled=true';
     }
 
-    // nitro modules on xcode 16.2 requires ios 16 version because of the bug https://github.com/swiftlang/swift/issues/77909
-    // full thread in https://github.com/mrousavy/nitro/issues/422
-    if (
-      config.project.viewConfig === 'nitro-view' ||
-      config.project.moduleConfig === 'nitro-modules'
-    ) {
-      const newTargetVersion = 16.0;
-
-      const podfile = await fs.readFile(
-        path.join(directory, 'ios', 'Podfile'),
-        'utf8'
-      );
-
-      const postInstallLine = 'post_install do |installer|';
-      // set pods deployement min version
-      const podVersionOverride = `
-    installer.pods_project.targets.each do |target|
-      target.build_configurations.each do |config|
-        config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '${newTargetVersion}'
-      end
-    end
-    `;
-
-      const insertionIndex = podfile.indexOf(postInstallLine);
-
-      if (insertionIndex !== -1) {
-        const endOfMarkerLineIndex = podfile.indexOf('\n', insertionIndex);
-
-        if (endOfMarkerLineIndex !== -1) {
-          const updatedPodfileContent =
-            podfile.slice(0, endOfMarkerLineIndex) +
-            podVersionOverride +
-            podfile.slice(endOfMarkerLineIndex);
-
-          await fs.writeFile(
-            path.join(directory, 'ios', 'Podfile'),
-            updatedPodfileContent
-          );
-        }
-      }
-
-      // set project deployement min version
-      const project = await fs.readFile(
-        path.join(
-          directory,
-          `ios/${config.project.name}Example.xcodeproj`,
-          'project.pbxproj'
-        ),
-        'utf8'
-      );
-
-      // match whole IPHONEOS_DEPLOYMENT_TARGET line
-      const deployementLineRegex =
-        /^(\s*)IPHONEOS_DEPLOYMENT_TARGET\s*=\s*[^;]+;$/gm;
-      const replacementPattern = `$1IPHONEOS_DEPLOYMENT_TARGET = ${newTargetVersion};`;
-      const updatedContent = project.replace(
-        deployementLineRegex,
-        replacementPattern
-      );
-
-      await fs.writeFile(
-        path.join(
-          directory,
-          `ios/${config.project.name}Example.xcodeproj`,
-          'project.pbxproj'
-        ),
-        updatedContent
-      );
-    }
-
     await fs.writeFile(
       path.join(directory, 'android', 'gradle.properties'),
       gradleProperties

packages/create-react-native-library/src/template.ts

@@ -156,6 +156,7 @@ function getModuleConfig(projectType: ProjectType): ModuleConfig {
       return 'turbo-modules';
     case 'fabric-view':
     case 'library':
+    case 'nitro-view':
       return null;
   }
 }

packages/create-react-native-library/templates/common/CONTRIBUTING.md

@@ -18,9 +18,8 @@ yarn
 ```
 
 > Since the project relies on Yarn workspaces, you cannot use [`npm`](https://github.com/npm/cli) for development.
-> <% if (project.moduleConfig === 'nitro-modules' || project.viewConfig === 'nitro-view') { -%>
 
-<% if (project.moduleConfig === 'nitro-modules') { -%>
+<% if (project.moduleConfig === 'nitro-modules' || project.viewConfig === 'nitro-view') { -%>
 This project uses Nitro Modules. If you're not familiar with how Nitro works, make sure to check the [Nitro Modules Docs](https://nitro.margelo.com/).
 
 You need to run [Nitrogen](https://nitro.margelo.com/docs/nitrogen) to generate the boilerplate code required for this project. The example app will not build without this step.
@@ -36,8 +35,6 @@ To invoke **Nitrogen**, use the following command:
 yarn nitrogen
 ```
 
-<% } -%>
-
 <% } -%>
 The [example app](/example/) demonstrates usage of the library. You need to run it to test any changes you make.
 

packages/create-react-native-library/templates/native-common/android/build.gradle

@@ -35,9 +35,8 @@ def getExtOrIntegerDefault(name) {
 }
 
 android {
-  if (supportsNamespace()) {
 <% if (project.moduleConfig === 'nitro-modules' || project.viewConfig === 'nitro-view') { -%>
-    namespace "com.margelo.nitro.<%- project.package -%>"
+  namespace "com.margelo.nitro.<%- project.package -%>"
 <% } else { -%>
   namespace "com.<%- project.package -%>"
 <% } -%>