feat: use node to call codegen #685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### SummaryWe were using `npx` to call the React Native Community CLI for codegen. However, not every environment has `npx` available. This adds custom logic to invoke the RNCCLI only using the node binary.### Test plan1. Create a new architecture supported library2. Call `yarn bob build --target codegen`3. Make sure the command passes without any problems4. Call `yarn prepare`
|
This will emit a much better error message in cases like #676 |
2 tasks
atlj
added a commit
that referenced
this pull request
Nov 21, 2024
### Summary Fixes #691 We created a custom way of calling the React Native Community CLI with #685. But it broke the easy workflow with monorepos. We made the original change to be able to call codegen build from XCode actions but since we dropped the support for that, we can revert the change back. This keeps the new file but uses the old method of calling the cil (npx). ### Test plan 1. Create a new project that supports the new architecture 2. Call `yarn prepare` and make sure everything passes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were using
npxto call the React Native Community CLIfor codegen. However, not every environment has
npxavailable. Thisadds custom logic to invoke the RNCCLI only using the node binary.
This also emits a better error message when the user doesn't have
@react-native-community/cliinstalled on their library project.Test plan
yarn bob build --target codegen