Potential bug in Android with codegen + `includesGeneratedCode`

[cortinico]

Description

We just got a report that there might be a misconfiguration in builder-bob for Android here: reactwg/react-native-new-architecture#272

The user mentioned they had to remove the if (isNewArchitectureEnabled()) { which I believe is not correct.

Can someone investigate this one?

Packages

• create-react-native-library
• react-native-builder-bob

Selected options

See comment above

Link to repro

reactwg/react-native-new-architecture#272

Environment

N/a

[satya164]

It's not exactly a bug in the template because they are modifying the new architecture template to add backward compatibility, and it's expected that a new architecture template needs changes to support old architecture.

In our case the isNewArchitectureEnabled() is just redundant since this template is for new architecture apps either way where this will be true. I made a PR to remove these checks #791

[Zach-Dean-Attractions-io]

Hi,

I have cloned the repo and ran create-react-native-library locally to test the changed.

If I create a Turbo module then the library generated works on both the new (tested v 0.78.0) and old architecture (tested v 0.75.0) as expected.

However, if I create a Fabric native component then the library generated only works on the new architecture (tested v 0.78.0). A standalone app running the old architecture (tested v 0.75.0) fails to build with the following error.

> Task :android-native-component:compileDebugKotlin FAILED
32 actionable tasks: 32 executed

info 💡 Tip: Make sure that you have set up your development environment correctly, by running npx react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor

e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath:
    class com.facebook.react.viewmanagers.AndroidNativeComponentViewManagerInterface, unresolved supertypes: ViewManagerWithGeneratedInterface
Adding -Xextended-compiler-checks argument might provide additional information.

e: file:///.../node_modules/android-native-component/android/src/main/java/com/androidnativecomponent/AndroidNativeComponentViewManager.kt:18:5 Cannot access 'ViewManagerWithGeneratedInterface' which is a supertype of 'com.androidnativecomponent.AndroidNativeComponentViewManager'. Check your module classpath for missing or conflicting dependencies
e: file:///.../node_modules/android-native-component/android/src/main/java/com/androidnativecomponent/AndroidNativeComponentViewManager.kt:18:59 Cannot access 'ViewManagerWithGeneratedInterface' which is a supertype of 'com.androidnativecomponent.AndroidNativeComponentViewManager'. Check your module classpath for missing or conflicting dependencies
e: file:///.../node_modules/android-native-component/android/src/main/java/com/androidnativecomponent/AndroidNativeComponentViewManager.kt:22:12 Cannot access 'ViewManagerWithGeneratedInterface' which is a supertype of 'com.androidnativecomponent.AndroidNativeComponentViewManager'. Check your module classpath for missing or conflicting dependencies
e: file:///.../node_modules/android-native-component/android/src/main/java/com/androidnativecomponent/AndroidNativeComponentViewManager.kt:12:1 Cannot access 'ViewManagerWithGeneratedInterface' which is a supertype of 'com.androidnativecomponent.AndroidNativeComponentViewManager'. Check your module classpath for missing or conflicting dependencies

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':android-native-component:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction
   > Compilation error. See log for more details

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 7s
error Failed to install the app. Command failed with exit code 1: ./gradlew app:installDebug -PreactNativeDevServerPort=8081
e: Supertypes of the following classes cannot be resolved. Please make sure you have the required dependencies in the classpath: class com.facebook.react.viewmanagers.AndroidNativeComponentViewManagerInterface, unresolved supertypes: ViewManagerWithGeneratedInterface
Adding -Xextended-compiler-checks argument might provide additional information. e: file:///.../node_modules/android-native-component/android/src/main/java/com/androidnativecomponent/AndroidNativeComponentViewManager.kt:12:1 Cannot access 'ViewManagerWithGeneratedInterface' which is a supertype of 'com.androidnativecomponent.AndroidNativeComponentViewManager'. Check your module classpath for missing or conflicting dependencies
e: file:///.../node_modules/android-native-component/android/src/main/java/com/androidnativecomponent/AndroidNativeComponentViewManager.kt:18:5 Cannot access 'ViewManagerWithGeneratedInterface' which is a supertype of 'com.androidnativecomponent.AndroidNativeComponentViewManager'. Check your module classpath for missing or conflicting dependencies
e: file:///.../node_modules/android-native-component/android/src/main/java/com/androidnativecomponent/AndroidNativeComponentViewManager.kt:18:59 Cannot access 'ViewManagerWithGeneratedInterface' which is a supertype of 'com.androidnativecomponent.AndroidNativeComponentViewManager'. Check your module classpath for missing or conflicting dependencies
e: file:///.../node_modules/android-native-component/android/src/main/java/com/androidnativecomponent/AndroidNativeComponentViewManager.kt:22:12 Cannot access 'ViewManagerWithGeneratedInterface' which is a supertype of 'com.androidnativecomponent.AndroidNativeComponentViewManager'. Check your module classpath for missing or conflicting dependencies FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':android-native-component:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction > Compilation error. See log for more details * Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org. BUILD FAILED in 7s.
info Run CLI with --verbose flag for more details.

To reproduce:

1. Run react-native-builder-bob/packages/create-react-native-library/bin/create-react-native-library AndroidNativeComponent using the main branch
2. package name: android-native-component
3. type: Fabric view
4. Run: cd AndroidNativeComponent && yarn
5. Published the library locally to test: npm publish --registry=http://localhost:4873/
6. Created an app running v 0.78.0 of React Native
   a. Run npx @react-native-community/cli@latest init myNewApp
   b. Install the library npm install android-native-component
   c. Modify App.tsx

import React from 'react';
import { SafeAreaView, Text,} from 'react-native';
import { AndroidNativeComponentView } from 'android-native-component'

function App(): React.JSX.Element {

  return (
    <SafeAreaView>
      <Text>Hello World!</Text>
      <AndroidNativeComponentView
        color='#ff00ff'
        style={{ width: 100, height: 100 }}
      />
    </SafeAreaView>
  );
}

export default App;

d. The native component displays as expected.
7. Created an app running v 0.75.0 of React Native
a. Run npx @react-native-community/cli@latest init myOldApp --version 0.75.0
b. Install the library npm install android-native-component
c. Modify App.tsx as above
d. Encounter the error above

I know you mentioned you'd expect changes to be required for adding backwards compatibility

It's not exactly a bug in the template because they are modifying the new architecture template to add backward compatibility, and it's expected that a new architecture template needs changes to support old architecture.

but what changes would these be as I don't believe they are documented anywhere and it goes against the official React Native documentation, which says that if you have includesGeneratedCode: true in the codegenConfig then Android backwards compatibility works for free.

No need to include two sets of files to support both architectures on Android. You can only keep the New Architecture one, and it is guaranteed to be backwards compatible.

https://reactnative.dev/docs/the-new-architecture/codegen-cli

I don't mind adding code to support the legacy architecture but I believe it should be documented somewhere that is easy to discover and implement.

[Zach-Dean-Attractions-io]

I have reverted the code in the PR and I still get the same issue, so this is probably an existing issue. Confirmed the issue reproduces using version 0.48.5 of create-react-native-library

[satya164]

We rely on React Native documentation to provide guidance on the topic.

If the documentation says it will work only with includesGeneratedCode: true and it doesn't work, then there are missing steps in the documentation.

If there's anything wrong in the template that prevents it, then we're happy to fix it. But we don't know what's needed if the documentation doesn't mention it. And it's not up to us to document how codegen works with the old architecture since we don't work on codegen.