Regression in create-react-native-library 0.43.0

[Johennes]

Description

With the release of react-native-builder-bob 0.40.0 we've started seeing build errors in our compatibility tests that use create-react-native-library 0.43.0 and react native 0.76.6: https://github.com/jhugman/uniffi-bindgen-react-native/actions/runs/14298161831/job/40068107837#step:3:1089

From what I can gather create-react-native-library@0.43.0 (from last November) sets the project up to use react-native-builder-bob@0.40.0 (from 3 days ago) which then breaks building the example app:

error [ERR_REQUIRE_ESM]: require() of ES Module /Users/jm/Code/turbo-module/node_modules/arktype/out/index.js from /Users/jm/Code/turbo-module/node_modules/react-native-builder-bob/lib/build.js not supported.

I'm not sure why the same doesn't happen with the latest version of create-react-native-library.

Packages

• create-react-native-library
• react-native-builder-bob

Selected options

We're running

./scripts/test-turbo-modules.sh \
    --slug '@my-org/my-lib' \
    --ubrn-config integration/fixtures/compat/ubrn.config.yaml \
    --builder-bob-version 0.43.0 \
    --rn-version 0.76.6 \
    --packgage-json-mixin integration/fixtures/compat/package.json \
    --react-native-config integration/fixtures/compat/react-native.config.js \
    --ios \
    ../turbo-module

with this script: https://github.com/jhugman/uniffi-bindgen-react-native/blob/main/scripts/test-turbo-modules.sh

Link to repro

https://github.com/jhugman/uniffi-bindgen-react-native/actions/runs/14298161831/job/40068107837#step:3:1089

Environment

GitHub actions on both Linux and macOS

[satya164]

Hey @Johennes, what's your Node version?

From latest release of react-native-builder-bob, we require at least Node v20.19.0 which is in our engines field

react-native-builder-bob/packages/react-native-builder-bob/package.json

Line 32 in 42a5872

"node": ">= 20.19.0"

If you're not using Node 20, we may need to update our engines field to restrict to compatible Node.js versions.

I also recommend using the .nvmrc file on GitHub actions to use a compatible version of Node.js like so

react-native-builder-bob/packages/create-react-native-library/templates/common/$.github/actions/setup/action.yml

Line 10 in 42a5872

node-version-file: .nvmrc

[satya164]

I have published new versions with better engines field. You should now get a warning if you're not using a compatible Node.js version.

[satya164]

The linked job is shows a different error from the issue: https://github.com/jhugman/uniffi-bindgen-react-native/actions/runs/14298161831/job/40068107837#step:3:1053

This a config validation error (targets[3][1].esm must be removed) - so check the property at this location in the config and remove it. You likely have esm: true in the typescript target which isn't a valid configuration option in the latest version, and we added configuration validation in the latest version.

I'm closing this since both of these are expected.

[Johennes]

Thanks for your help @satya164. Is it intentional that old versions of create-react-native-library set up projects that use new versions of react-native-builder-bob? We're using create-react-native-library to verify another library generation project and every now and again our CI breaks even though we use a pinned version of create-react-native-library.

[satya164]

@Johennes it just uses the latest version of react-native-builder-bob from npm, any other way would take a bit of work to achieve and it hasn't been necessary.

this is the first time there has been a breaking change in react-native-builder-bob (and no future breaking changes are planned) so i think the CI breaking in the past is unrelated to this.

it could've been something else like a change in react native community cli that we use to init the example, etc. but i don't know. if something breaks next time, please open an issue so we can take a look and figure out if we need to pin something.