From 0fddf44e8fbbfb83d11254f6c2921d6a6612d1bb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Burak=20Gu=CC=88ner?= Date: Mon, 27 Jan 2025 22:17:26 +0300 Subject: [PATCH 1/3] fix: treat js-only libs as legacy arch --- packages/create-react-native-library/src/template.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/create-react-native-library/src/template.ts b/packages/create-react-native-library/src/template.ts index dd7507a12..946784e94 100644 --- a/packages/create-react-native-library/src/template.ts +++ b/packages/create-react-native-library/src/template.ts @@ -104,7 +104,9 @@ export function generateTemplateConfiguration({ const { slug, languages, type } = answers; const arch = - type === 'legacy-module' || type === 'legacy-view' ? 'legacy' : 'new'; + type === 'legacy-module' || type === 'legacy-view' || type === 'library' + ? 'legacy' + : 'new'; const project = slug.replace(/^(react-native-|@[^/]+\/)/, ''); let namespace: string | undefined; From f0ce21f4ef64f91c2b0ac9bced472dd0afe670fc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Burak=20Gu=CC=88ner?= Date: Tue, 28 Jan 2025 11:07:21 +0300 Subject: [PATCH 2/3] fix: legacy arch example app template fails on js --- .../templates/example-module-legacy/example/src/App.tsx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/create-react-native-library/templates/example-module-legacy/example/src/App.tsx b/packages/create-react-native-library/templates/example-module-legacy/example/src/App.tsx index cbf4dc6c7..136ca264b 100644 --- a/packages/create-react-native-library/templates/example-module-legacy/example/src/App.tsx +++ b/packages/create-react-native-library/templates/example-module-legacy/example/src/App.tsx @@ -2,6 +2,7 @@ import { useState, useEffect } from 'react'; import { Text, View, StyleSheet } from 'react-native'; import { multiply } from '<%- project.slug -%>'; +<% if (project.native) { -%> export default function App() { const [result, setResult] = useState(); @@ -9,6 +10,11 @@ export default function App() { multiply(3, 7).then(setResult); }, []); +<% } else { -%> +const result = multiply(3, 7); + +export default function App() { +<% } -%> return ( Result: {result} From 0e80065372e4c15386345fbb91608cf61aea6ac5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Burak=20Gu=CC=88ner?= Date: Tue, 28 Jan 2025 11:18:39 +0300 Subject: [PATCH 3/3] fix unused imports --- .../templates/example-module-legacy/example/src/App.tsx | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/create-react-native-library/templates/example-module-legacy/example/src/App.tsx b/packages/create-react-native-library/templates/example-module-legacy/example/src/App.tsx index 136ca264b..05c7d3ad5 100644 --- a/packages/create-react-native-library/templates/example-module-legacy/example/src/App.tsx +++ b/packages/create-react-native-library/templates/example-module-legacy/example/src/App.tsx @@ -1,8 +1,8 @@ -import { useState, useEffect } from 'react'; -import { Text, View, StyleSheet } from 'react-native'; import { multiply } from '<%- project.slug -%>'; - +import { Text, View, StyleSheet } from 'react-native'; <% if (project.native) { -%> +import { useState, useEffect } from 'react'; + export default function App() { const [result, setResult] = useState(); @@ -11,6 +11,7 @@ export default function App() { }, []); <% } else { -%> + const result = multiply(3, 7); export default function App() {