Skip to content

Commit c859d13

Browse files
committed
Address review comments
1 parent 672f43a commit c859d13

File tree

5 files changed

+15
-8
lines changed

5 files changed

+15
-8
lines changed

.github/actions/install-dependencies/action.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,10 @@ inputs:
44
node-version:
55
description: 'The Node.js version to set up'
66
required: false
7-
7+
lookup-only:
8+
description: 'If true, only checks if cache entry exists and skips download. Default: false'
9+
required: false
10+
default: false
811

912
runs:
1013
using: 'composite'
@@ -21,6 +24,7 @@ runs:
2124
key: ${{ runner.os }}-yarn-example-${{ hashFiles('./example/yarn.lock') }}
2225
restore-keys: ${{ runner.os }}-yarn-example-
2326
path: ${{ github.workspace }}/example/node_modules
27+
lookup-only: ${{ inputs.lookup-only }}
2428

2529

2630
- name: Install example node_modules
@@ -51,6 +55,7 @@ runs:
5155
key: ${{ runner.os }}-yarn-${{ hashFiles('./yarn.lock') }}
5256
restore-keys: ${{ runner.os }}-yarn-
5357
path: ${{ github.workspace }}/node_modules
58+
lookup-only: ${{ inputs.lookup-only }}
5459

5560

5661
- name: Install node_modules

.github/workflows/main.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ jobs:
2525
with:
2626
fetch-depth: 0
2727
- uses: ./.github/actions/install-dependencies
28+
with:
29+
lookup-only: true
2830

2931
code-quality:
3032
name: Code Quality
@@ -38,13 +40,13 @@ jobs:
3840
- uses: ./.github/actions/install-dependencies
3941

4042
- name: Lint files
41-
run: yarn run lint
43+
run: yarn lint
4244

4345
- name: Types check
44-
run: yarn run ts
46+
run: yarn ts
4547

4648
- name: Lib build
47-
run: yarn run build
49+
run: yarn build
4850

4951
build-android:
5052
name: Build Android

example/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"extends": "@tsconfig/react-native/tsconfig.json"
2+
"extends": "../tsconfig.json"
33
}

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@
4949
"ts": "yarn tsc --noEmit",
5050
"lint": "eslint '**/*.{js,ts,tsx}'",
5151
"release": "release-it",
52-
"build": "rm -rf lib/* && bob build && prettier --write ./lib",
53-
"prepublishOnly": "yarn run build"
52+
"build": "bob build",
53+
"prepack": "yarn run build"
5454
},
5555
"peerDependencies": {
5656
"react-native": ">=0.57.0"

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"extends": "@react-native/typescript-config/tsconfig.json",
33
"compilerOptions": {
44
"types": ["react-native"],
5-
"baseUrl": "./",
5+
"rootDir": "./",
66
"paths": {
77
"@react-native-community/image-editor": ["./src/index"]
88
}

0 commit comments

Comments
 (0)