Skip to content

Commit 31c85c1

Browse files
troZeePiotr Trocki
andauthored
chore(CI): turn off flipper on CI (#645)
* chore(CI): turn off flipper on CI * chore(CI): turn off flipper on CI * turn off flipper * Add NO_FLIPPER flag Co-authored-by: Piotr Trocki <[email protected]>
1 parent df647e1 commit 31c85c1

File tree

3 files changed

+13
-9
lines changed

3 files changed

+13
-9
lines changed

.github/workflows/ios.yml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,14 @@
11
name: iOS Build
22

33
on:
4-
push:
4+
push:
55
paths:
66
- '.github/workflows/ios.yml'
77
- 'ios/**'
88
- 'example/ios/**'
99
- 'fabricexample/ios/**'
1010

11-
concurrency:
11+
concurrency:
1212
group: ${{ github.ref }}-ios
1313
cancel-in-progress: true
1414

@@ -50,12 +50,12 @@ jobs:
5050

5151
- name: Install required dependencies on cache miss (Pods)
5252
if: steps.cache-pods.outputs.cache-hit != 'true'
53-
run: pod install
53+
run: NO_FLIPPER=1 pod install
5454
working-directory: example/ios
5555

5656
- name: Reinstall Pods only if using cached ones
5757
if: steps.cache-pods.outputs.cache-hit == 'true'
58-
run: pod install
58+
run: NO_FLIPPER=1 pod install
5959
working-directory: example/ios
6060

6161
- name: Build iOS
@@ -83,7 +83,7 @@ jobs:
8383
with:
8484
path: fabricexample/node_modules
8585
key: ${{ hashFiles('./fabricexample/yarn.lock') }}-${{ hashFiles('./yarn.lock') }}
86-
86+
8787
- name: Install required fabric example dependencies on yarn.lock change
8888
if: steps.cache-fabricexample-npm.outputs.cache-hit != 'true'
8989
shell: bash
@@ -101,12 +101,12 @@ jobs:
101101

102102
- name: Install FabricExample required dependencies on cache miss (Pods)
103103
if: steps.cache-pods-fabric.outputs.cache-hit != 'true'
104-
run: pod install
104+
run: NO_FLIPPER=1 pod install
105105
working-directory: fabricexample/ios
106106

107107
- name: Reinstall FabricExample Pods only if using cached ones
108108
if: steps.cache-pods-fabric.outputs.cache-hit == 'true'
109-
run: pod install
109+
run: NO_FLIPPER=1 pod install
110110
working-directory: fabricexample/ios
111111

112112
- name: Build iOS (Fabric)

example/ios/Podfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ install! 'cocoapods', :deterministic_uuids => false
66

77
ENV['RCT_NEW_ARCH_ENABLED'] = '0'
88

9+
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled
10+
911
target 'PagerViewExample' do
1012
config = use_native_modules!
1113

@@ -23,7 +25,7 @@ target 'PagerViewExample' do
2325
#
2426
# Note that if you have use_frameworks! enabled, Flipper will not work and
2527
# you should disable the next line.
26-
:flipper_configuration => FlipperConfiguration.enabled,
28+
:flipper_configuration => flipper_config,
2729
# An absolute path to your application root.
2830
:app_path => "#{Pod::Config.instance.installation_root}/.."
2931
)

fabricexample/ios/Podfile

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ require_relative '../node_modules/@react-native-community/cli-platform-ios/nativ
55
platform :ios, '12.4'
66
install! 'cocoapods', :deterministic_uuids => false
77

8+
flipper_config = ENV['NO_FLIPPER'] == "1" ? FlipperConfiguration.disabled : FlipperConfiguration.enabled
9+
810
target 'FabricExample' do
911
config = use_native_modules!
1012

@@ -22,7 +24,7 @@ target 'FabricExample' do
2224
#
2325
# Note that if you have use_frameworks! enabled, Flipper will not work and
2426
# you should disable the next line.
25-
:flipper_configuration => FlipperConfiguration.enabled,
27+
:flipper_configuration => flipper_config,
2628
# An absolute path to your application root.
2729
:app_path => "#{Pod::Config.instance.installation_root}/.."
2830
)

0 commit comments

Comments
 (0)