fix(android): remove the redundant PageSelectedEvent dispatch causing an ANR on RN 0.72 (#770)

igorbej · web-flow · commit 51738d87402e · 2023-09-25T13:15:30.000+02:00
diff --git a/android/src/fabric/java/com/reactnativepagerview/PagerViewViewManager.kt b/android/src/fabric/java/com/reactnativepagerview/PagerViewViewManager.kt
@@ -183,10 +183,6 @@ class PagerViewViewManager : ViewGroupManager<NestedScrollableHost>(), RNCViewPa
         val canScroll = childCount != null && childCount > 0 && selectedPage >= 0 && selectedPage < childCount
         if (canScroll) {
             PagerViewViewManagerImpl.setCurrentItem(view, selectedPage, scrollWithAnimation)
-            val reactContext = view.context as ReactContext
-            UIManagerHelper.getEventDispatcherForReactTag(reactContext, view.id)?.dispatchEvent(
-                    PageSelectedEvent(view.id, selectedPage)
-            )
         }
     }
 
diff --git a/android/src/paper/java/com/reactnativepagerview/PagerViewViewManager.kt b/android/src/paper/java/com/reactnativepagerview/PagerViewViewManager.kt
@@ -146,7 +146,6 @@ class PagerViewViewManager : ViewGroupManager<NestedScrollableHost>() {
                 if (canScroll) {
                     val scrollWithAnimation = commandId == COMMAND_SET_PAGE
                     PagerViewViewManagerImpl.setCurrentItem(view, pageIndex, scrollWithAnimation)
-                    eventDispatcher.dispatchEvent(PageSelectedEvent(root.id, pageIndex))
                 }
             }
             COMMAND_SET_SCROLL_ENABLED -> {

Original file line number	Diff line number	Diff line change
`@@ -183,10 +183,6 @@ class PagerViewViewManager : ViewGroupManager<NestedScrollableHost>(), RNCViewPa`
`183`	`183`	`val canScroll = childCount != null && childCount > 0 && selectedPage >= 0 && selectedPage < childCount`
`184`	`184`	`if (canScroll) {`
`185`	`185`	`PagerViewViewManagerImpl.setCurrentItem(view, selectedPage, scrollWithAnimation)`
`186`		`- val reactContext = view.context as ReactContext`
`187`		`- UIManagerHelper.getEventDispatcherForReactTag(reactContext, view.id)?.dispatchEvent(`
`188`		`- PageSelectedEvent(view.id, selectedPage)`
`189`		`- )`
`190`	`186`	`}`
`191`	`187`	`}`
`192`	`188`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,6 @@ class PagerViewViewManager : ViewGroupManager<NestedScrollableHost>() {`
`146`	`146`	`if (canScroll) {`
`147`	`147`	`val scrollWithAnimation = commandId == COMMAND_SET_PAGE`
`148`	`148`	`PagerViewViewManagerImpl.setCurrentItem(view, pageIndex, scrollWithAnimation)`
`149`		`- eventDispatcher.dispatchEvent(PageSelectedEvent(root.id, pageIndex))`
`150`	`149`	`}`
`151`	`150`	`}`
`152`	`151`	`COMMAND_SET_SCROLL_ENABLED -> {`