Skip to content

Commit 69a7494

Browse files
authored
fix(ios): NSInternalInconsistencyException crash (#564)
Added additional checks to scroll without animation if already an animation is in progress to fix `NSInternalInconsistencyException` crash in iOS
1 parent 6fb5cfa commit 69a7494

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

ios/ReactNativePageView.m

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ - (void)goTo:(NSInteger)index animated:(BOOL)animated {
264264
if (i == _currentIndex) {
265265
continue;
266266
}
267-
[self goToViewController:i direction:direction animated:animated shouldCallOnPageSelected: i == index];
267+
[self goToViewController:i direction:direction animated:(!self.animating && i == index) shouldCallOnPageSelected: i == index];
268268
}
269269
}
270270

@@ -274,12 +274,12 @@ - (void)goTo:(NSInteger)index animated:(BOOL)animated {
274274
if (i == _currentIndex || i >= numberOfPages) {
275275
continue;
276276
}
277-
[self goToViewController:i direction:direction animated:animated shouldCallOnPageSelected: i == index];
277+
[self goToViewController:i direction:direction animated:(!self.animating && i == index) shouldCallOnPageSelected: i == index];
278278
}
279279
}
280280

281281
if (diff == 0) {
282-
[self goToViewController:index direction:direction animated:animated shouldCallOnPageSelected:YES];
282+
[self goToViewController:index direction:direction animated:NO shouldCallOnPageSelected:YES];
283283
}
284284
}
285285

0 commit comments

Comments
 (0)