fix: correct label color for v2 (#3711)

Author: lukewalczak

src/components/BottomNavigation/utils.ts

@@ -59,11 +59,10 @@ export const getLabelColor = ({
     return tintColor;
   }
 
-  if (focused) {
-    return theme.colors.onSurface;
-  }
-
   if (theme.isV3) {
+    if (focused) {
+      return theme.colors.onSurface;
+    }
     return theme.colors.onSurfaceVariant;
   }
 

src/components/__tests__/BottomNavigation.test.tsx

@@ -518,6 +518,7 @@ describe('getLabelColor', () => {
     ${undefined} | ${true}  | ${'#fff'}    | ${true}  | ${MD3Colors.neutral10}
     ${undefined} | ${false} | ${'#fff'}    | ${true}  | ${MD3Colors.neutralVariant30}
     ${undefined} | ${false} | ${'#fff'}    | ${false} | ${'#fff'}
+    ${undefined} | ${true}  | ${'#fff'}    | ${false} | ${'#fff'}
   `(
     'returns $expected when tintColor: $tintColor, focused: $focused useV3: $useV3',
     ({ tintColor, focused, defaultColor, useV3, expected }) => {