-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Description
Current behaviour
Using surfaceContainer color gives following error in TypeScript:
Property 'surfaceContainer' does not exist on type 'MD3Colors'.ts(2339)
After looking at Type MD3Colors, I found out these Colors are not included in React-Native-Paper's MD3Color type :
surfaceContainer
surfaceContainerHigh
surfaceContainerHighest
surfaceContainerLow
surfaceContainerLowest
Note:
There are 2 MD3Colors .
The one I am talking about is atypefromnode_modules\react-native-paper\src\types.tsx, which contains type definitions.
The otherMD3Colorsis aconst objectfrom filenode_modules\react-native-paper\src\styles\themes\v3\tokens.tsx
which contains palette
Expected behaviour
These colors should be included in MD3Colors and should not get any error's as these are part of Material You's Color Roles :

I used useMaterial3Theme from pchmn/expo-material3-theme to generate my theme colors, and it gives all the SurfaceContainer colors. But Paper's default theme and Type MD3Colors don't have it. So whenever I use SurfaceContainer Colors, I get errors in VS Code. Just want to know why is it not included ?
How to reproduce?
Create expo app
Install react-native-paper
Try using surfaceContianer Color to a background of View, You will get error.
Preview
What have you tried so far?
Nothing much, except, editing MD3Colors type in and including all missing colors, but I still got the error. I don't really know how these things work.
I checked React-Native-Paper's docs on Theming, but even there, there's no word about surfaceContianer Colors. I think it's just not included/was missed while creating paper's MD3Colors or was not present in Material You by that time, but now it is and should be included in paper too. Surface Container and its variants are unique and provides amazing theming for surfaces. Please try to include them as fast as possible β¨.
Your Environment
| software | version |
|---|---|
| android | 13 |
| react-native | 0.72.10 |
| react-native-paper | 5.11.1 |
| node | 20.10.0 |
| npm or yarn | 1.22.21 |
| expo sdk | 50.0.13 |
