Skip to content

Conversation

@aravind3566
Copy link

Fix: Correct ThemeProp import path in SegmentedButtons.tsx

This pull request corrects the import path for ThemeProp in SegmentedButtons.tsx. The original import path was incorrect, leading to a broken build or runtime errors.

Motivation:

The current import import type { ThemeProp } from 'src/types'; is relative to the component's location and does not correctly resolve the ThemeProp type. This change updates the import to the correct relative path: import type { ThemeProp } from '../../../src/types';

Related Issue:

(If applicable, link to the related issue here. Otherwise, leave this section blank or describe the problem.)

Test Plan:

  1. Build the project. Verify that the build succeeds without errors related to ThemeProp.
  2. Run the application and ensure that the Segmented Buttons functionality works as expected. Confirm that there are no runtime errors related to the ThemeProp type.

This commit resolves this issue by fixing the import statement. The change involves a single addition and deletion within SegmentedButtons.tsx. The pull request is mergeable and passes lint, TypeScript, and tests.

@aravind3566 aravind3566 changed the title Fixed ThemeProp mapping SegmentedButtons.tsx Fixed ThemeProp mapping Nov 7, 2024
@aravind3566 aravind3566 changed the title SegmentedButtons.tsx Fixed ThemeProp mapping Fixed ThemeProp mapping - SegmentedButtons.tsx Nov 7, 2024
@callstack-bot
Copy link

Hey @aravind3566, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@aravind3566 aravind3566 marked this pull request as draft November 7, 2024 07:30
@aravind3566 aravind3566 closed this Nov 7, 2024
@aravind3566 aravind3566 deleted the patch-2 branch November 7, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants