chore: deprecate createMaterialBottomTabNavigator
#4694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @lukewalczak, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here. |
lukewalczak
force-pushed
the
chore/support-navigation-v7
branch
from
d226905 to
b606414
Compare
lukewalczak
changed the title
createMaterialBottomTabNavigator
lukewalczak
force-pushed
the
chore/support-navigation-v7
branch
3 times, most recently
from
00332b0 to
4b3831e
Compare
lukewalczak
force-pushed
the
chore/support-navigation-v7
branch
from
4b3831e to
52a0642
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
createMaterialBottomTabNavigatordeprecationThis merge request drops support for
createMaterialBottomTabNavigator, reflecting its deprecation since version5.14.0ofreact-native-paper.For historical context,
createMaterialBottomTabNavigatorwas introduced as part of thereact-native-paperlibrary due to its ability to animate transitions between tabs. Currently, the same feature, along with many others, is supported in the latest version of@react-navigation/bottom-tabs.Supporting
createMaterialBottomTabNavigatorfor both versions ofreact-navigationcomes with typing issues that will require different annotations.The example and related references to
MaterialBottomTabNavigatorExamplehave been deleted to prevent confusion and to encourage migration to the supported solution.createBottomTabNavigatoras replacementThe documentation has been updated to clearly inform users about the deprecation and to recommend using
createBottomTabNavigatorfrom@react-navigation/bottom-tabsversion7.xor higher in combination withBottomNavigation.Barfor a Material Design look.Users can also explore the snack example, which demonstrates how to combine
createBottomTabNavigatorwithBottomNavigation.Bar.Related issue
Fixes: #4601
Fixes: #4572
Test plan